Issue 4406 - Treat about:srcdoc as not having an own security context, inherit document origin

Issue 4406 - Treat about:srcdoc as not having an own security context, inherit document origin

[lainverse, 2016-09-12 15:24:17]

On 2016/09/12 11:57:05, Wladimir Palant wrote:

Why not to define array like this:
var aboutLocations = ["about:blank", "moz-safe-about:blank", "about:srcdoc"];

To use aboutLocations.indexOf(frame.location) > -1 later on?

I think it's more readable this way.

[Wladimir Palant, 2016-09-12 18:17:54]

On 2016/09/12 15:24:17, lainverse wrote:
> Why not to define array like this:
> var aboutLocations = ["about:blank", "moz-safe-about:blank", "about:srcdoc"];
> 
> To use aboutLocations.indexOf(frame.location) > -1 later on?
> 
> I think it's more readable this way.

It's also consistently 10-15 times slower on Firefox.

[lainverse, 2016-09-12 21:31:19]

On 2016/09/12 18:17:54, Wladimir Palant wrote:
> It's also consistently 10-15 times slower on Firefox.
Wow! It's also 14 times faster than the same thing in the Google Chrome. Didn't
thought there could be such a huge difference.

[Wladimir Palant, 2016-09-13 06:56:40]

On 2016/09/12 21:31:19, lainverse wrote:
> On 2016/09/12 18:17:54, Wladimir Palant wrote:
> > It's also consistently 10-15 times slower on Firefox.
> Wow! It's also 14 times faster than the same thing in the Google Chrome.
Didn't
> thought there could be such a huge difference.

Always depends on the scenarios that the particular JavaScript engine optimizes.
String comparison offers plenty of room for optimization.

[kzar, 2016-09-13 10:07:07]

LGTM