Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(358)

Issue 29352919: Issue 4419 - Use proper API in order to upload devbuilds to AMO (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 2 months ago by Wladimir Palant
Modified:
3 years, 2 months ago
Reviewers:
Sebastian Noack
Base URL:
https://hg.adblockplus.org/sitescripts
Visibility:
Public.

Description

Issue 4419 - Use proper API in order to upload devbuilds to AMO

Patch Set 1 #

Patch Set 2 : Got rid of unnecessary opener object #

Total comments: 6

Patch Set 3 : Addressed review comments #

Total comments: 2

Patch Set 4 : Addressed another nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -97 lines) Patch
M .sitescripts.example View 1 chunk +2 lines, -2 lines 0 comments Download
M sitescripts/extensions/bin/createNightlies.py View 1 2 3 3 chunks +45 lines, -95 lines 0 comments Download

Messages

Total messages: 6
Wladimir Palant
3 years, 2 months ago (2016-09-13 14:12:28 UTC) #1
Sebastian Noack
https://codereview.adblockplus.org/29352919/diff/29352926/sitescripts/extensions/bin/createNightlies.py File sitescripts/extensions/bin/createNightlies.py (right): https://codereview.adblockplus.org/29352919/diff/29352926/sitescripts/extensions/bin/createNightlies.py#newcode408 sitescripts/extensions/bin/createNightlies.py:408: input = '.'.join([ '{}.{}'.format(...) seems more appropriate rather than ...
3 years, 2 months ago (2016-09-13 15:03:12 UTC) #2
Wladimir Palant
https://codereview.adblockplus.org/29352919/diff/29352926/sitescripts/extensions/bin/createNightlies.py File sitescripts/extensions/bin/createNightlies.py (right): https://codereview.adblockplus.org/29352919/diff/29352926/sitescripts/extensions/bin/createNightlies.py#newcode408 sitescripts/extensions/bin/createNightlies.py:408: input = '.'.join([ On 2016/09/13 15:03:12, Sebastian Noack wrote: ...
3 years, 2 months ago (2016-09-13 15:16:54 UTC) #3
Sebastian Noack
https://codereview.adblockplus.org/29352919/diff/29352929/sitescripts/extensions/bin/createNightlies.py File sitescripts/extensions/bin/createNightlies.py (right): https://codereview.adblockplus.org/29352919/diff/29352929/sitescripts/extensions/bin/createNightlies.py#newcode439 sitescripts/extensions/bin/createNightlies.py:439: e.close() Generally, you should use try-finally (or with statement, ...
3 years, 2 months ago (2016-09-13 15:28:06 UTC) #4
Wladimir Palant
https://codereview.adblockplus.org/29352919/diff/29352929/sitescripts/extensions/bin/createNightlies.py File sitescripts/extensions/bin/createNightlies.py (right): https://codereview.adblockplus.org/29352919/diff/29352929/sitescripts/extensions/bin/createNightlies.py#newcode439 sitescripts/extensions/bin/createNightlies.py:439: e.close() On 2016/09/13 15:28:06, Sebastian Noack wrote: > Generally, ...
3 years, 2 months ago (2016-09-13 15:45:20 UTC) #5
Sebastian Noack
3 years, 2 months ago (2016-09-13 15:53:15 UTC) #6
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5