Issue 4419 - Use proper API in order to upload devbuilds to AMO

Issue 4419 - Use proper API in order to upload devbuilds to AMO

[Sebastian Noack, 2016-09-13 15:03:12]

https://codereview.adblockplus.org/29352919/diff/29352926/sitescripts/extensi...
File sitescripts/extensions/bin/createNightlies.py (right):

https://codereview.adblockplus.org/29352919/diff/29352926/sitescripts/extensi...
sitescripts/extensions/bin/createNightlies.py:408: input = '.'.join([
'{}.{}'.format(...) seems more appropriate rather than using a list literal
(with fixed amount of elements) just for the matter of joining it. Same below.

https://codereview.adblockplus.org/29352919/diff/29352926/sitescripts/extensi...
sitescripts/extensions/bin/createNightlies.py:418: upload_url =
('https://addons.mozilla.org/api/v3/addons/{0}/'
Nit: Note that the indices in the placeholders are optional if you access them
in the order the values are given like you do here.

https://codereview.adblockplus.org/29352919/diff/29352926/sitescripts/extensi...
sitescripts/extensions/bin/createNightlies.py:438: logging.error(e.read())
The error response should be closed as well.

[Wladimir Palant, 2016-09-13 15:16:54]

https://codereview.adblockplus.org/29352919/diff/29352926/sitescripts/extensi...
File sitescripts/extensions/bin/createNightlies.py (right):

https://codereview.adblockplus.org/29352919/diff/29352926/sitescripts/extensi...
sitescripts/extensions/bin/createNightlies.py:408: input = '.'.join([
On 2016/09/13 15:03:12, Sebastian Noack wrote:
> '{}.{}'.format(...) seems more appropriate rather than using a list literal
> (with fixed amount of elements) just for the matter of joining it. Same below.

Done.

https://codereview.adblockplus.org/29352919/diff/29352926/sitescripts/extensi...
sitescripts/extensions/bin/createNightlies.py:418: upload_url =
('https://addons.mozilla.org/api/v3/addons/{0}/'
On 2016/09/13 15:03:12, Sebastian Noack wrote:
> Nit: Note that the indices in the placeholders are optional if you access them
> in the order the values are given like you do here.

Done.

https://codereview.adblockplus.org/29352919/diff/29352926/sitescripts/extensi...
sitescripts/extensions/bin/createNightlies.py:438: logging.error(e.read())
On 2016/09/13 15:03:12, Sebastian Noack wrote:
> The error response should be closed as well.

Done.

[Sebastian Noack, 2016-09-13 15:28:06]

https://codereview.adblockplus.org/29352919/diff/29352929/sitescripts/extensi...
File sitescripts/extensions/bin/createNightlies.py (right):

https://codereview.adblockplus.org/29352919/diff/29352929/sitescripts/extensi...
sitescripts/extensions/bin/createNightlies.py:439: e.close()
Generally, you should use try-finally (or with statement, however, that is not
supported here) to make sure that the resource gets closed no matter what.

[Wladimir Palant, 2016-09-13 15:45:20]

https://codereview.adblockplus.org/29352919/diff/29352929/sitescripts/extensi...
File sitescripts/extensions/bin/createNightlies.py (right):

https://codereview.adblockplus.org/29352919/diff/29352929/sitescripts/extensi...
sitescripts/extensions/bin/createNightlies.py:439: e.close()
On 2016/09/13 15:28:06, Sebastian Noack wrote:
> Generally, you should use try-finally (or with statement, however, that is not
> supported here) to make sure that the resource gets closed no matter what.

And here I was hoping that we could avoid obfuscating this code too much...
Done.

[Sebastian Noack, 2016-09-13 15:53:15]

LGTM