Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29354754: Issue 4467 - Fixed hex encoding of characters in string literal and adjusted tests for newer Spider… (Closed)

Created:
Sept. 23, 2016, 10:50 a.m. by Wladimir Palant
Modified:
Sept. 23, 2016, 11:24 a.m.
Reviewers:
kzar
Base URL:
https://hg.adblockplus.org/jshydra
Visibility:
Public.

Description

Issue 4467 - Fixed hex encoding of characters in string literal and adjusted tests for newer SpiderMonkey versions

Patch Set 1 #

Patch Set 2 : Better approach #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -60 lines) Patch
M autotest/abprewrite_source.js View 1 chunk +16 lines, -14 lines 0 comments Download
M autotest/test_abprewrite.js.expected View 3 chunks +16 lines, -15 lines 0 comments Download
M autotest/test_abprewrite_autoload.js.expected View 3 chunks +16 lines, -15 lines 0 comments Download
M autotest/test_abprewrite_module.js.expected View 3 chunks +16 lines, -15 lines 0 comments Download
M scripts/astDecompile.js View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
Wladimir Palant
Sept. 23, 2016, 10:50 a.m. (2016-09-23 10:50:40 UTC) #1
Wladimir Palant
After thinking a bit more about it I changed the fix - the original code ...
Sept. 23, 2016, 10:58 a.m. (2016-09-23 10:58:21 UTC) #2
kzar
Sept. 23, 2016, 11:07 a.m. (2016-09-23 11:07:36 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld