Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(194)

Issue 29354778: Issue 4466 - Remove rsa.js, update core + buildtools (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 12 months ago by kzar
Modified:
2 years, 11 months ago
Visibility:
Public.

Description

Issue 4466 - Remove rsa.js, update core + buildtools Depends on https://codereview.adblockplus.org/29354773/

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removed signature tests, they are tested in adblockpluscore #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1092 lines) Patch
M dependencies View 1 chunk +2 lines, -2 lines 0 comments Download
D lib/jsbn.js View 1 chunk +0 lines, -587 lines 0 comments Download
D lib/rsa.js View 1 chunk +0 lines, -193 lines 0 comments Download
D lib/sha1.js View 1 chunk +0 lines, -173 lines 0 comments Download
M lib/whitelisting.js View 1 chunk +1 line, -0 lines 0 comments Download
M metadata.common View 1 3 chunks +3 lines, -7 lines 0 comments Download
M qunit/tests/signatures.js View 1 1 chunk +0 lines, -130 lines 0 comments Download

Messages

Total messages: 5
kzar
Patch Set 1
2 years, 12 months ago (2016-09-23 12:43:54 UTC) #1
Sebastian Noack
LGTM
2 years, 12 months ago (2016-09-23 12:44:43 UTC) #2
Wladimir Palant
https://codereview.adblockplus.org/29354778/diff/29354779/qunit/tests/signatures.js File qunit/tests/signatures.js (right): https://codereview.adblockplus.org/29354778/diff/29354779/qunit/tests/signatures.js#newcode18 qunit/tests/signatures.js:18: let {verifySignature} = require("rsa"); Please don't just update this ...
2 years, 12 months ago (2016-09-23 12:50:38 UTC) #3
kzar
Patch Set 2 : Removed signature tests, they are tested in adblockpluscore https://codereview.adblockplus.org/29354778/diff/29354779/qunit/tests/signatures.js File qunit/tests/signatures.js ...
2 years, 12 months ago (2016-09-23 13:52:22 UTC) #4
Wladimir Palant
2 years, 12 months ago (2016-09-23 20:03:48 UTC) #5
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5