Issue 29354778: Issue 4466 - Remove rsa.js, update core + buildtools

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29354778: Issue 4466 - Remove rsa.js, update core + buildtools (Closed)

Created:
Sept. 23, 2016, 12:41 p.m. by kzar

Modified:
Sept. 25, 2016, 1:32 p.m.

Reviewers:
Sebastian Noack, Wladimir Palant

Visibility:
Public.

Description

Issue 4466 - Remove rsa.js, update core + buildtools Depends on https://codereview.adblockplus.org/29354773/

Patch Set 2 : Removed signature tests, they are tested in adblockpluscore #

Created: Sept. 23, 2016, 1:51 p.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1092 lines)			Patch
M	dependencies	View		1 chunk	+2 lines, -2 lines	0 comments	Download
D	lib/jsbn.js	View		1 chunk	+0 lines, -587 lines	0 comments	Download
D	lib/rsa.js	View		1 chunk	+0 lines, -193 lines	0 comments	Download
D	lib/sha1.js	View		1 chunk	+0 lines, -173 lines	0 comments	Download
M	lib/whitelisting.js	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	metadata.common	View	1	3 chunks	+3 lines, -7 lines	0 comments	Download
M	qunit/tests/signatures.js	View	1	1 chunk	+0 lines, -130 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Wladimir Palant

https://codereview.adblockplus.org/29354778/diff/29354779/qunit/tests/signatures.js File qunit/tests/signatures.js (right): https://codereview.adblockplus.org/29354778/diff/29354779/qunit/tests/signatures.js#newcode18 qunit/tests/signatures.js:18: let {verifySignature} = require("rsa"); Please don't just update this ...

Sept. 23, 2016, 12:50 p.m. (2016-09-23 12:50:38 UTC) #3

kzar

Patch Set 2 : Removed signature tests, they are tested in adblockpluscore https://codereview.adblockplus.org/29354778/diff/29354779/qunit/tests/signatures.js File qunit/tests/signatures.js ...

Sept. 23, 2016, 1:52 p.m. (2016-09-23 13:52:22 UTC) #4

LGTM

Expand All Messages | Collapse All Messages