Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29355231: Fixes 4479 - Default editorconfig settings not being applied (Closed)

Created:
Sept. 28, 2016, 7:42 a.m. by Felix Dahlke
Modified:
Oct. 10, 2016, 1:28 p.m.
CC:
Wladimir Palant
Base URL:
https://bitbucket.org/fhd/codingtools
Visibility:
Public.

Description

Fixes 4479 - Default editorconfig settings not being applied

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M editorconfig View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6
Felix Dahlke
Sept. 28, 2016, 7:43 a.m. (2016-09-28 07:43:01 UTC) #1
Vasily Kuznetsov
On 2016/09/28 07:43:01, Felix Dahlke wrote: LGTM
Sept. 28, 2016, 1:01 p.m. (2016-09-28 13:01:36 UTC) #2
juliandoucette
LGTM
Sept. 28, 2016, 1:04 p.m. (2016-09-28 13:04:21 UTC) #3
juliandoucette
On 2016/09/28 13:04:21, juliandoucette wrote: > LGTM fhd or Vasily, are you going to push ...
Oct. 6, 2016, 1:10 p.m. (2016-10-06 13:10:01 UTC) #4
Felix Dahlke
On 2016/10/06 13:10:01, juliandoucette wrote: > On 2016/09/28 13:04:21, juliandoucette wrote: > > LGTM > ...
Oct. 10, 2016, 1:27 p.m. (2016-10-10 13:27:04 UTC) #5
Felix Dahlke
Oct. 10, 2016, 1:27 p.m. (2016-10-10 13:27:06 UTC) #6
On 2016/10/06 13:10:01, juliandoucette wrote:
> On 2016/09/28 13:04:21, juliandoucette wrote:
> > LGTM
> 
> fhd or Vasily, are you going to push and close?

Dropped from my radar, sorry. Pushing now :)

Powered by Google App Engine
This is Rietveld