Issue 29355239: Issue 4481 - Scripts should expect the language selector to be missing, e.g. on the blog

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29355239: Issue 4481 - Scripts should expect the language selector to be missing, e.g. on the blog (Closed)

Created:
Sept. 28, 2016, 11:10 a.m. by Wladimir Palant

Modified:
Sept. 28, 2016, 12:58 p.m.

Reviewers:
juliandoucette, saroyanm

Base URL:
https://hg.adblockplus.org/web.adblockplus.org/

Visibility:
Public.

Description

Issue 4481 - Scripts should expect the language selector to be missing, e.g. on the blog

Patch Set 1 #

Total comments: 1

Created: Sept. 28, 2016, 11:10 a.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	static/js/main.js	View		2 chunks	+4 lines, -1 line	1 comment	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

saroyanm

LGTM with a small Detail https://codereview.adblockplus.org/29355239/diff/29355240/static/js/main.js File static/js/main.js (right): https://codereview.adblockplus.org/29355239/diff/29355240/static/js/main.js#newcode51 static/js/main.js:51: if (!language) Detail: I ...

Sept. 28, 2016, 12:34 p.m. (2016-09-28 12:34:27 UTC) #2

saroyanm

On 2016/09/28 12:34:27, saroyanm wrote: > LGTM with a small Detail > > https://codereview.adblockplus.org/29355239/diff/29355240/static/js/main.js > ...

Sept. 28, 2016, 12:45 p.m. (2016-09-28 12:45:48 UTC) #3

juliandoucette

Sept. 28, 2016, 12:51 p.m. (2016-09-28 12:51:44 UTC) #4

On 2016/09/28 12:34:27, saroyanm wrote:
> LGTM with a small Detail
> 
> https://codereview.adblockplus.org/29355239/diff/29355240/static/js/main.js
> File static/js/main.js (right):
> 
>
https://codereview.adblockplus.org/29355239/diff/29355240/static/js/main.js#n...
> static/js/main.js:51: if (!language)
> Detail: I think it make sense to have a small comment that we don't have
> language selector in the blogs.

LGTM

Expand All Messages | Collapse All Messages