Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29355276: Noissue - Remove usage of the deprecated Promises.jsm module. (Closed)

Created:
Sept. 29, 2016, 12:31 p.m. by sergei
Modified:
Oct. 4, 2016, 10:53 a.m.
Visibility:
Public.

Description

# project abpcrawler

Patch Set 1 #

Patch Set 2 : address comments #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -20 lines) Patch
M lib/crawler.js View 1 4 chunks +10 lines, -11 lines 1 comment Download
M lib/main.js View 2 chunks +3 lines, -9 lines 0 comments Download

Messages

Total messages: 4
sergei
> Also, please don't leave out the reject parameter even though you aren't using it. ...
Sept. 29, 2016, 12:45 p.m. (2016-09-29 12:45:08 UTC) #1
Wladimir Palant
On 2016/09/29 12:45:08, sergei wrote: > Why is this done different way here > https://github.com/adblockplus/adblockpluscore/blob/master/lib/events.js#L70? ...
Sept. 29, 2016, 6:23 p.m. (2016-09-29 18:23:35 UTC) #2
sergei
Fixed, tested in FF 45.
Sept. 29, 2016, 9 p.m. (2016-09-29 21:00:27 UTC) #3
Wladimir Palant
Sept. 30, 2016, 6:08 a.m. (2016-09-30 06:08:33 UTC) #4
LGTM

https://codereview.adblockplus.org/29355276/diff/29355371/lib/crawler.js
File lib/crawler.js (right):

https://codereview.adblockplus.org/29355276/diff/29355371/lib/crawler.js#newc...
lib/crawler.js:137: this._deferred = new Map();
I would normally ask you to rename this property but this code will be gone soon
anyway...

Powered by Google App Engine
This is Rietveld