Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29355735: Issue 4223 - Remove tests migrated to adblockpluscore (Closed)

Created:
Oct. 4, 2016, 1:19 p.m. by kzar
Modified:
Oct. 4, 2016, 2:54 p.m.
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

Issue 4223 - Remove tests migrated to adblockpluscore

Patch Set 1 #

Total comments: 2

Patch Set 2 : Restored elemhide.js #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2065 lines) Patch
D chrome/content/tests/cssRules.js View 1 chunk +0 lines, -75 lines 0 comments Download
D chrome/content/tests/domainRestrictions.js View 1 chunk +0 lines, -155 lines 0 comments Download
D chrome/content/tests/filterClasses.js View 1 chunk +0 lines, -307 lines 0 comments Download
D chrome/content/tests/filterListener.js View 1 chunk +0 lines, -280 lines 0 comments Download
D chrome/content/tests/filterNotifier.js View 1 chunk +0 lines, -75 lines 0 comments Download
D chrome/content/tests/filterStorage.js View 1 chunk +0 lines, -458 lines 0 comments Download
D chrome/content/tests/matcher.js View 1 chunk +0 lines, -207 lines 0 comments Download
D chrome/content/tests/regexpFilters_matching.js View 1 chunk +0 lines, -314 lines 0 comments Download
D chrome/content/tests/signatures.js View 1 chunk +0 lines, -130 lines 0 comments Download
D chrome/content/tests/subscriptionClasses.js View 1 chunk +0 lines, -64 lines 0 comments Download

Messages

Total messages: 4
kzar
Patch Set 1
Oct. 4, 2016, 1:20 p.m. (2016-10-04 13:20:07 UTC) #1
Wladimir Palant
https://codereview.adblockplus.org/29355735/diff/29355736/chrome/content/tests/elemhide.js File chrome/content/tests/elemhide.js (left): https://codereview.adblockplus.org/29355735/diff/29355736/chrome/content/tests/elemhide.js#oldcode1 chrome/content/tests/elemhide.js:1: (function() This test wasn't migrated, elemhide.js in adblockpluscore repository ...
Oct. 4, 2016, 1:53 p.m. (2016-10-04 13:53:18 UTC) #2
kzar
Patch Set 2 : Restored elemhide.js https://codereview.adblockplus.org/29355735/diff/29355736/chrome/content/tests/elemhide.js File chrome/content/tests/elemhide.js (left): https://codereview.adblockplus.org/29355735/diff/29355736/chrome/content/tests/elemhide.js#oldcode1 chrome/content/tests/elemhide.js:1: (function() On 2016/10/04 ...
Oct. 4, 2016, 2:20 p.m. (2016-10-04 14:20:44 UTC) #3
Wladimir Palant
Oct. 4, 2016, 2:42 p.m. (2016-10-04 14:42:42 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld