Issue 4223 - Adapt notification tests to work in adblockpluscore repository

test/notification.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 "use strict";
 
 let {
   createSandbox, setupTimerAndXMLHttp, setupRandomResult, unexpectedError, Cr
 } = require("./_common");
 
 let info = null;
-let sandboxedJSON = JSON;

[kzar, 2016/10/05 12:46:30]

This variable doesn't seem to be used?

[Wladimir Palant, 2016/10/05 12:50:42]

Right, a left-over from a previous attempt at fixing instanceof checks.

 let Prefs = null;
 let Notification = null;
 
 exports.setUp = function(callback)
 {
+  // Inject our Array and JSON to make sure that instanceof checks on arrays
+  // within the sandbox succeed even with data passed in from outside.
   let globals = Object.assign({Array, JSON},
     setupTimerAndXMLHttp.call(this), setupRandomResult.call(this));
 
   let sandboxedRequire = createSandbox({globals});
-

[kzar, 2016/10/05 12:46:30]

Nit: This newline is inconsistent with the other test files.

[Wladimir Palant, 2016/10/05 12:50:42]

Done.

   (
     info = sandboxedRequire("./stub-modules/info"),
     {Prefs} = sandboxedRequire("./stub-modules/prefs"),
     {Notification} = sandboxedRequire("../lib/notification")
   );
 
   callback();
 };
 
 function showNotifications(url)
@@ skipping 403 matching lines @@
   test.done();
 };
 
 exports.testMissingTranslation = function(test)
 {
   let notification = {message: {"en-US": "en-US"}};
   let texts = Notification.getLocalizedTexts(notification, "fr");
   test.equal(texts.message, "en-US");
   test.done();
 };