Issue 4223 - Adapt notification tests to work in adblockpluscore repository

Issue 4223 - Adapt notification tests to work in adblockpluscore repository

[Wladimir Palant, 2016-10-05 12:34:13]

https://codereview.adblockplus.org/29356001/diff/29356002/test/_common.js
File test/_common.js (right):

https://codereview.adblockplus.org/29356001/diff/29356002/test/_common.js#new...
test/_common.js:153: exports.setupTimerAndXMLHttp = function()
The contents of this function and the ones below merely moved from
synchronizer.js, no functional changes.

[kzar, 2016-10-05 12:46:30]

https://codereview.adblockplus.org/29356001/diff/29356002/test/_common.js
File test/_common.js (right):

https://codereview.adblockplus.org/29356001/diff/29356002/test/_common.js#new...
test/_common.js:153: exports.setupTimerAndXMLHttp = function()
On 2016/10/05 12:34:13, Wladimir Palant wrote:
> The contents of this function and the ones below merely moved from
> synchronizer.js, no functional changes.

Acknowledged.

https://codereview.adblockplus.org/29356001/diff/29356002/test/notification.js
File test/notification.js (right):

https://codereview.adblockplus.org/29356001/diff/29356002/test/notification.j...
test/notification.js:25: let sandboxedJSON = JSON;
This variable doesn't seem to be used?

https://codereview.adblockplus.org/29356001/diff/29356002/test/notification.j...
test/notification.js:35: 
Nit: This newline is inconsistent with the other test files.

[Wladimir Palant, 2016-10-05 12:50:42]

https://codereview.adblockplus.org/29356001/diff/29356002/test/notification.js
File test/notification.js (right):

https://codereview.adblockplus.org/29356001/diff/29356002/test/notification.j...
test/notification.js:25: let sandboxedJSON = JSON;
On 2016/10/05 12:46:30, kzar wrote:
> This variable doesn't seem to be used?

Right, a left-over from a previous attempt at fixing instanceof checks.

https://codereview.adblockplus.org/29356001/diff/29356002/test/notification.j...
test/notification.js:35: 
On 2016/10/05 12:46:30, kzar wrote:
> Nit: This newline is inconsistent with the other test files.

Done.

[kzar, 2016-10-05 12:54:02]

LGTM

[kzar, 2016-10-05 13:18:39]

(If this is the last test we're migrating perhaps remove the "We're currently
migrating the tests..." message from the README here?)

[Wladimir Palant, 2016-10-05 14:53:43]

On 2016/10/05 13:18:39, kzar wrote:
> (If this is the last test we're migrating perhaps remove the "We're currently
> migrating the tests..." message from the README here?)

I have one more in the pipeline, will think about removing this line.