Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(186)

Issue 29357374: Issue 4527 - Don't access potentially dead object in child/elemHide.js (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 4 months ago by Wladimir Palant
Modified:
3 years, 4 months ago
Reviewers:
kzar
Base URL:
https://hg.adblockplus.org/adblockplus
Visibility:
Public.

Description

As explained in the issue, we only verify that window is not a dead object - subject (which is a document) can apparently be dead even if the window is not.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M lib/child/elemHide.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2
Wladimir Palant
3 years, 4 months ago (2016-10-14 08:41:59 UTC) #1
kzar
3 years, 4 months ago (2016-10-14 17:02:39 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5