Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29357374: Issue 4527 - Don't access potentially dead object in child/elemHide.js (Closed)

Created:
Oct. 14, 2016, 8:41 a.m. by Wladimir Palant
Modified:
Oct. 15, 2016, 9:14 p.m.
Reviewers:
kzar
Base URL:
https://hg.adblockplus.org/adblockplus
Visibility:
Public.

Description

As explained in the issue, we only verify that window is not a dead object - subject (which is a document) can apparently be dead even if the window is not.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M lib/child/elemHide.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2
Wladimir Palant
Oct. 14, 2016, 8:41 a.m. (2016-10-14 08:41:59 UTC) #1
kzar
Oct. 14, 2016, 5:02 p.m. (2016-10-14 17:02:39 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld