Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29357569: Issue 4533 - Don't rely on the default namespace to be XUL for DevTools (Closed)

Created:
Oct. 17, 2016, 9 a.m. by Wladimir Palant
Modified:
Oct. 17, 2016, 2:23 p.m.
Reviewers:
saroyanm
Base URL:
https://hg.adblockplus.org/elemhidehelper
Visibility:
Public.

Description

Issue 4533 - Don't rely on the default namespace to be XUL for DevTools

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M lib/inspectorObserver.js View 1 chunk +4 lines, -1 line 1 comment Download

Messages

Total messages: 2
Wladimir Palant
Oct. 17, 2016, 9 a.m. (2016-10-17 09:00:13 UTC) #1
saroyanm
Oct. 17, 2016, 12:02 p.m. (2016-10-17 12:02:09 UTC) #2
https://codereview.adblockplus.org/29357569/diff/29357570/lib/inspectorObserv...
File lib/inspectorObserver.js (right):

https://codereview.adblockplus.org/29357569/diff/29357570/lib/inspectorObserv...
lib/inspectorObserver.js:65:
"http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul",
LGTM

Powered by Google App Engine
This is Rietveld