Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29357572: Issue 4536 - Make sure the elements stay hidden after adding the filter (Closed)

Created:
Oct. 17, 2016, 9:58 a.m. by Wladimir Palant
Modified:
Oct. 17, 2016, 2:51 p.m.
Reviewers:
saroyanm
Base URL:
https://hg.adblockplus.org/elemhidehelper
Visibility:
Public.

Description

Issue 4536 - Make sure the elements stay hidden after adding the filter

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M chrome/content/composer.js View 2 chunks +7 lines, -3 lines 2 comments Download
M chrome/content/composer.xul View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3
Wladimir Palant
Oct. 17, 2016, 9:58 a.m. (2016-10-17 09:58:39 UTC) #1
saroyanm
LGTM https://codereview.adblockplus.org/29357572/diff/29357573/chrome/content/composer.js File chrome/content/composer.js (left): https://codereview.adblockplus.org/29357572/diff/29357573/chrome/content/composer.js#oldcode16 chrome/content/composer.js:16: let previewStyle = null; I assume it's irrelevant ...
Oct. 17, 2016, 2:41 p.m. (2016-10-17 14:41:44 UTC) #2
Wladimir Palant
Oct. 17, 2016, 2:51 p.m. (2016-10-17 14:51:29 UTC) #3
https://codereview.adblockplus.org/29357572/diff/29357573/chrome/content/comp...
File chrome/content/composer.js (left):

https://codereview.adblockplus.org/29357572/diff/29357573/chrome/content/comp...
chrome/content/composer.js:16: let previewStyle = null;
On 2016/10/17 14:41:44, saroyanm wrote:
> I assume it's irrelevant to the review, but redundant variable.

Yes, became redundant due to E10S adjustments and was overlooked apparently.

Powered by Google App Engine
This is Rietveld