Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29357590: Issue 4539 - Document new $websocket filter type (Closed)

Created:
Oct. 17, 2016, 11:27 a.m. by Wladimir Palant
Modified:
Oct. 17, 2016, 7:12 p.m.
Base URL:
https://hg.adblockplus.org/web.adblockplus.org/
Visibility:
Public.

Description

Issue 4539 - Document new $websocket filter type

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M pages/filters.html View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5
Wladimir Palant
Oct. 17, 2016, 11:27 a.m. (2016-10-17 11:27:13 UTC) #1
saroyanm
https://codereview.adblockplus.org/29357590/diff/29357591/pages/filters.html File pages/filters.html (right): https://codereview.adblockplus.org/29357590/diff/29357591/pages/filters.html#newcode154 pages/filters.html:154: <li>{{websocket <code><fix>websocket</fix></code> — requests initiated via <a href="https://developer.mozilla.org/en-US/docs/Web/API/WebSocket"><code><fix>WebSocket</fix></code> object</a> ...
Oct. 17, 2016, 11:35 a.m. (2016-10-17 11:35:28 UTC) #2
saroyanm
https://codereview.adblockplus.org/29357590/diff/29357591/pages/filters.html File pages/filters.html (right): https://codereview.adblockplus.org/29357590/diff/29357591/pages/filters.html#newcode154 pages/filters.html:154: <li>{{websocket <code><fix>websocket</fix></code> — requests initiated via <a href="https://developer.mozilla.org/en-US/docs/Web/API/WebSocket"><code><fix>WebSocket</fix></code> object</a> ...
Oct. 17, 2016, 11:42 a.m. (2016-10-17 11:42:06 UTC) #3
Wladimir Palant
https://codereview.adblockplus.org/29357590/diff/29357591/pages/filters.html File pages/filters.html (right): https://codereview.adblockplus.org/29357590/diff/29357591/pages/filters.html#newcode154 pages/filters.html:154: <li>{{websocket <code><fix>websocket</fix></code> — requests initiated via <a href="https://developer.mozilla.org/en-US/docs/Web/API/WebSocket"><code><fix>WebSocket</fix></code> object</a> ...
Oct. 17, 2016, 2:47 p.m. (2016-10-17 14:47:59 UTC) #4
saroyanm
Oct. 17, 2016, 4:24 p.m. (2016-10-17 16:24:31 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld