Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29358499: Issue 4550 - ABP / edge loses the custom filters / lists (Closed)

Oct. 21, 2016, 1:20 p.m. by Oleksandr
Oct. 22, 2016, 4:05 p.m.
Sebastian Noack, kzar


We were in fact loosing the last subscription from the storage. Not necessarily custom filters. This happened because we did not notify the parser that the processing has finished, so that meant INIParser did not add filters to the last subscription.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M lib/adblockplus.js View 1 chunk +1 line, -0 lines 0 comments Download


Total messages: 2
Oct. 21, 2016, 1:23 p.m. (2016-10-21 13:23:32 UTC) #1
Sebastian Noack
Oct. 21, 2016, 1:49 p.m. (2016-10-21 13:49:21 UTC) #2
LGTM. But can you please update the issue, cleaning up it's description so that
it is less speculative, but describes the actual bug.

Powered by Google App Engine
This is Rietveld