Issue 29359623: Issue 3819 - Add Jobs link to the footer

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29359623: Issue 3819 - Add Jobs link to the footer (Closed)

Created:
Oct. 25, 2016, 10:52 a.m. by saroyanm

Modified:
Oct. 25, 2016, 12:19 p.m.

Reviewers:
juliandoucette

Visibility:
Public.

Description

Issue 3819 - Add Jobs link to the footer

Patch Set 1 #

Total comments: 3

Created: Oct. 25, 2016, 10:52 a.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	locales/en/menu.json	View		1 chunk	+3 lines, -0 lines	0 comments	Download
	M	templates/default.tmpl	View		1 chunk	+1 line, -0 lines	3 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

juliandoucette

Quick question. https://codereview.adblockplus.org/29359623/diff/29359624/templates/default.tmpl File templates/default.tmpl (right): https://codereview.adblockplus.org/29359623/diff/29359624/templates/default.tmpl#newcode185 templates/default.tmpl:185: <li><a href="https://eyeo.com/jobs/" hreflang="en">{{get_string("jobs", "menu")}}</a></li> Why are we ...

Oct. 25, 2016, 11:15 a.m. (2016-10-25 11:15:23 UTC) #2

saroyanm

https://codereview.adblockplus.org/29359623/diff/29359624/templates/default.tmpl File templates/default.tmpl (right): https://codereview.adblockplus.org/29359623/diff/29359624/templates/default.tmpl#newcode185 templates/default.tmpl:185: <li><a href="https://eyeo.com/jobs/" hreflang="en">{{get_string("jobs", "menu")}}</a></li> On 2016/10/25 11:15:22, juliandoucette wrote: ...

Oct. 25, 2016, 12:09 p.m. (2016-10-25 12:09:19 UTC) #3

juliandoucette

Oct. 25, 2016, 12:15 p.m. (2016-10-25 12:15:46 UTC) #4

LGTM

https://codereview.adblockplus.org/29359623/diff/29359624/templates/default.tmpl
File templates/default.tmpl (right):

https://codereview.adblockplus.org/29359623/diff/29359624/templates/default.t...
templates/default.tmpl:185: <li><a href="https://eyeo.com/jobs/"
hreflang="en">{{get_string("jobs", "menu")}}</a></li>
On 2016/10/25 12:09:19, saroyanm wrote:
> On 2016/10/25 11:15:22, juliandoucette wrote:
> > Why are we using get_string here?
> 
> get_string is using a file to select the string, if I'll use translate
function
> I'll need to specify the translation for each page separately, I think this is
> an issue as well in the AA website (ex.:
>
https://hg.adblockplus.org/web.acceptableads.com/file/tip/includes/navbar.tmp...)
> still needs to be addressed in the reviews I guess.
> If you want to see the result in crowdin, you can run the test repo I created
> for the translation test on test crowdin project we have:
>
https://bitbucket.org/saroyanm/translation-script-test/src/17b537493d4fdb551f...
> 

Acknowledged.

Expand All Messages | Collapse All Messages