Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29359889: Issue 2292 - Add a disclaimer text on all landing pages in French language that provide the user li… (Closed)

Created:
Oct. 25, 2016, 3:53 p.m. by juliandoucette
Modified:
Oct. 27, 2016, 9:53 a.m.
Reviewers:
saroyanm
Visibility:
Public.

Description

This includes: - pages from #2295 - changed notification style on adware page - changed notification style on homepage - including maxthon notification - including wrong browser notification - changed class name on uninstall page to avoid confusion Sorry about the scope creep. I thought it was worth doing notification/alert/disclaimers consistently.

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -66 lines) Patch
A includes/fr-download-disclaimer.tmpl View 1 chunk +5 lines, -0 lines 0 comments Download
M includes/index.tmpl View 1 chunk +10 lines, -14 lines 0 comments Download
A includes/zh-maxthon-notification.tmpl View 1 chunk +5 lines, -0 lines 0 comments Download
M pages/adware.md View 2 chunks +2 lines, -8 lines 0 comments Download
M pages/customizations.html View 1 chunk +2 lines, -0 lines 0 comments Download
M pages/elemhidehelper.html View 1 chunk +2 lines, -0 lines 0 comments Download
M pages/uninstalled.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M static/css/index.css View 2 chunks +26 lines, -39 lines 2 comments Download
M static/css/index-mobile.css View 2 chunks +2 lines, -3 lines 0 comments Download
M static/css/main.css View 1 chunk +20 lines, -0 lines 1 comment Download
M static/css/simple.css View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 4
juliandoucette
Oct. 25, 2016, 3:53 p.m. (2016-10-25 15:53:33 UTC) #1
juliandoucette
On 2016/10/25 15:53:33, juliandoucette wrote: - Updated description - Ready for review - It's not ...
Oct. 25, 2016, 3:59 p.m. (2016-10-25 15:59:30 UTC) #2
saroyanm
In general I'd consider this design change for the warning messages as a separate issue: ...
Oct. 26, 2016, 5:31 p.m. (2016-10-26 17:31:18 UTC) #3
juliandoucette
Oct. 27, 2016, 9:53 a.m. (2016-10-27 09:53:21 UTC) #4
Acknowledged. 

I have uploaded a new review for #2295 and will address these issues separately
like you suggested.

Powered by Google App Engine
This is Rietveld