Issue 29359972: Issue 2295 - Add French disclaimer text to the pages that are currently missing it

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29359972: Issue 2295 - Add French disclaimer text to the pages that are currently missing it (Closed)

Created:
Oct. 27, 2016, 9:51 a.m. by juliandoucette

Modified:
Nov. 4, 2016, 11:40 a.m.

Reviewers:
saroyanm

Visibility:
Public.

Patch Set 1 #

Total comments: 3

Created: Oct. 27, 2016, 10:24 a.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -0 lines)			Patch
A	includes/fr-download-disclaimer.tmpl	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	pages/customizations.html	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	pages/elemhidehelper.html	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	static/css/main.css	View	1 chunk	+19 lines, -0 lines	3 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

saroyanm

Just 1 comment https://codereview.adblockplus.org/29359972/diff/29359996/static/css/main.css File static/css/main.css (right): https://codereview.adblockplus.org/29359972/diff/29359996/static/css/main.css#newcode445 static/css/main.css:445: .alert Why alert, but not warning ...

Oct. 27, 2016, 1:22 p.m. (2016-10-27 13:22:52 UTC) #2

juliandoucette

Thanks Manvel :-) Find your answer below. https://codereview.adblockplus.org/29359972/diff/29359996/static/css/main.css File static/css/main.css (right): https://codereview.adblockplus.org/29359972/diff/29359996/static/css/main.css#newcode445 static/css/main.css:445: .alert On ...

Oct. 27, 2016, 1:37 p.m. (2016-10-27 13:37:47 UTC) #3

saroyanm

Oct. 27, 2016, 1:42 p.m. (2016-10-27 13:42:42 UTC) #4

LGTM

https://codereview.adblockplus.org/29359972/diff/29359996/static/css/main.css
File static/css/main.css (right):

https://codereview.adblockplus.org/29359972/diff/29359996/static/css/main.css...
static/css/main.css:445: .alert
On 2016/10/27 13:37:47, juliandoucette wrote:
> On 2016/10/27 13:22:52, saroyanm wrote:
> > Why alert, but not warning or notification ?
> 
> 1. Alert makes sense (definition wise)
> 2. .warning and .disclaimer are defined differently in other CSS files and on
> other pages
I assume .warning and .disclaimer that are defined differently will share same
style soon.
> IMO
> - "notification" implies a popup (like a push notification)
> - "warning" implies fine print (like a warning label on drugs)
> - "alert" implies feedback (based on something about the user or their
actions)
For me "alert" is always associating with alert popup messages, but I do not
have strong opinion.

Expand All Messages | Collapse All Messages