Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(58)

Issue 29360039: Issue 4576 - Reinstate FilterStorage read/write integration test and test with please_kill_startup… (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years ago by Wladimir Palant
Modified:
3 years ago
Reviewers:
kzar
Base URL:
https://hg.adblockplus.org/adblockplustests
Visibility:
Public.

Description

Issue 4576 - Reinstate FilterStorage read/write integration test and test with please_kill_startup_performance switch

Patch Set 1 #

Total comments: 8

Patch Set 2 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -0 lines) Patch
M chrome/content/common.js View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/content/tests/filterStorage_readwrite.js View 1 1 chunk +141 lines, -0 lines 0 comments Download

Messages

Total messages: 4
Wladimir Palant
3 years ago (2016-10-28 09:34:02 UTC) #1
kzar
https://codereview.adblockplus.org/29360039/diff/29360040/chrome/content/tests/filterStorage_readwrite.js File chrome/content/tests/filterStorage_readwrite.js (right): https://codereview.adblockplus.org/29360039/diff/29360040/chrome/content/tests/filterStorage_readwrite.js#newcode22 chrome/content/tests/filterStorage_readwrite.js:22: for (let i = 0; i <40000; i++) Nit: ...
3 years ago (2016-10-28 10:23:56 UTC) #2
Wladimir Palant
https://codereview.adblockplus.org/29360039/diff/29360040/chrome/content/tests/filterStorage_readwrite.js File chrome/content/tests/filterStorage_readwrite.js (right): https://codereview.adblockplus.org/29360039/diff/29360040/chrome/content/tests/filterStorage_readwrite.js#newcode22 chrome/content/tests/filterStorage_readwrite.js:22: for (let i = 0; i <40000; i++) On ...
3 years ago (2016-10-28 11:09:38 UTC) #3
kzar
3 years ago (2016-10-28 11:17:05 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5