Issue 4576 - Reinstate FilterStorage read/write integration test and test with please_kill_startup…

Issue 4576 - Reinstate FilterStorage read/write integration test and test with please_kill_startup_performance switch

[kzar, 2016-10-28 10:23:56]

https://codereview.adblockplus.org/29360039/diff/29360040/chrome/content/test...
File chrome/content/tests/filterStorage_readwrite.js (right):

https://codereview.adblockplus.org/29360039/diff/29360040/chrome/content/test...
chrome/content/tests/filterStorage_readwrite.js:22: for (let i = 0; i <40000;
i++)
Nit: Missing space before the 40000.

https://codereview.adblockplus.org/29360039/diff/29360040/chrome/content/test...
chrome/content/tests/filterStorage_readwrite.js:23: lines.push("[Filter]",
`text=foobar${i}`, `hitCount=${i+10}`, `lastHit=${i+1400000000000}`);
Nit: Mind wrapping some of these long lines?

https://codereview.adblockplus.org/29360039/diff/29360040/chrome/content/test...
chrome/content/tests/filterStorage_readwrite.js:57: function
canonizeFiltersData(data)
Could be wrong here but shouldn't it be canonicalize?

https://codereview.adblockplus.org/29360039/diff/29360040/chrome/content/test...
chrome/content/tests/filterStorage_readwrite.js:87: return
sections.map(function(section) {
Nit: Arrow function? (Same in the sort above.)

[Wladimir Palant, 2016-10-28 11:09:38]

https://codereview.adblockplus.org/29360039/diff/29360040/chrome/content/test...
File chrome/content/tests/filterStorage_readwrite.js (right):

https://codereview.adblockplus.org/29360039/diff/29360040/chrome/content/test...
chrome/content/tests/filterStorage_readwrite.js:22: for (let i = 0; i <40000;
i++)
On 2016/10/28 10:23:56, kzar wrote:
> Nit: Missing space before the 40000.

Done.

https://codereview.adblockplus.org/29360039/diff/29360040/chrome/content/test...
chrome/content/tests/filterStorage_readwrite.js:23: lines.push("[Filter]",
`text=foobar${i}`, `hitCount=${i+10}`, `lastHit=${i+1400000000000}`);
On 2016/10/28 10:23:56, kzar wrote:
> Nit: Mind wrapping some of these long lines?

Done.

https://codereview.adblockplus.org/29360039/diff/29360040/chrome/content/test...
chrome/content/tests/filterStorage_readwrite.js:57: function
canonizeFiltersData(data)
On 2016/10/28 10:23:56, kzar wrote:
> Could be wrong here but shouldn't it be canonicalize?

Whatever, was the name used by the original test :)

https://codereview.adblockplus.org/29360039/diff/29360040/chrome/content/test...
chrome/content/tests/filterStorage_readwrite.js:87: return
sections.map(function(section) {
On 2016/10/28 10:23:56, kzar wrote:
> Nit: Arrow function? (Same in the sort above.)

It's old code that I didn't touch but sure.

[kzar, 2016-10-28 11:17:05]

LGTM