chrome/content/common.js - Issue 29360039: Issue 4576 - Reinstate FilterStorage read/write integration test and test with please_kill_startup…

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: chrome/content/common.js

Issue 29360039: Issue 4576 - Reinstate FilterStorage read/write integration test and test with please_kill_startup… (Closed) Base URL: https://hg.adblockplus.org/adblockplustests

Patch Set: Addressed comments Created Oct. 28, 2016, 11:09 a.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/content/common.js

===================================================================

--- a/chrome/content/common.js

+++ b/chrome/content/common.js

@@ -60,16 +60,17 @@ function prepareFilterComponents(keepLis

subscriptions: FilterStorage.subscriptions,

storageKnown: FilterStorage.knownSubscriptions,

subscriptionsKnown: Subscription.knownSubscriptions,

filtersKnown: Filter.knownFilters,

listeners: FilterNotifierGlobal.listeners,

sourceFile: FilterStorage.sourceFile

};

+ FilterStorage._loading = false;

FilterStorage.subscriptions = [];

FilterStorage.knownSubscriptions = Object.create(null);

Subscription.knownSubscriptions = Object.create(null);

Filter.knownFilters = Object.create(null);

if (!keepListeners)

{

FilterNotifierGlobal.listeners = [];

}

« no previous file with comments | « no previous file | chrome/content/tests/filterStorage_readwrite.js » ('j') | no next file with comments »