Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29360043: Issue 4575 - Fix failing tests in buildtools (Closed)

Created:
Oct. 28, 2016, 10:37 a.m. by Vasily Kuznetsov
Modified:
Dec. 5, 2016, 12:02 p.m.
Reviewers:
Sebastian Noack
CC:
kzar
Visibility:
Public.

Description

Override the mime type of 'otf' to always be 'application/octet-stream' to be consistent between Python versions and with MS and FB packagers. Repository: https://hg.adblockplus.org/buildtools Base revision: 1055332acedc

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address comments on patch set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M packagerEdge.py View 1 1 chunk +3 lines, -1 line 0 comments Download
M releaseAutomation.py View 1 chunk +1 line, -0 lines 0 comments Download
M tests/test_packagerEdge.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
Vasily Kuznetsov
Oct. 28, 2016, 10:40 a.m. (2016-10-28 10:40:26 UTC) #1
Sebastian Noack
https://codereview.adblockplus.org/29360043/diff/29360044/packagerEdge.py File packagerEdge.py (right): https://codereview.adblockplus.org/29360043/diff/29360044/packagerEdge.py#newcode117 packagerEdge.py:117: '.otf': 'application/octet-stream', Why not using 'application/font-sfnt' or 'application/x-font-sfnt'? https://codereview.adblockplus.org/29360043/diff/29360044/packagerEdge.py#newcode123 ...
Oct. 28, 2016, 12:43 p.m. (2016-10-28 12:43:53 UTC) #2
Vasily Kuznetsov
https://codereview.adblockplus.org/29360043/diff/29360044/packagerEdge.py File packagerEdge.py (right): https://codereview.adblockplus.org/29360043/diff/29360044/packagerEdge.py#newcode117 packagerEdge.py:117: '.otf': 'application/octet-stream', On 2016/10/28 12:43:51, Sebastian Noack wrote: > ...
Nov. 30, 2016, 3:11 p.m. (2016-11-30 15:11:46 UTC) #3
Sebastian Noack
Dec. 5, 2016, 11:53 a.m. (2016-12-05 11:53:07 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld