Issue 4575 - Fix failing tests in buildtools

Override the mime type of 'otf' to always be 'application/octet-stream' to be consistent between Python versions and with MS and FB packagers.

Repository: https://hg.adblockplus.org/buildtools
Base revision: 1055332acedc

[Sebastian Noack, 2016-10-28 12:43:53]

https://codereview.adblockplus.org/29360043/diff/29360044/packagerEdge.py
File packagerEdge.py (right):

https://codereview.adblockplus.org/29360043/diff/29360044/packagerEdge.py#new...
packagerEdge.py:117: '.otf': 'application/octet-stream',
Why not using 'application/font-sfnt' or 'application/x-font-sfnt'?

https://codereview.adblockplus.org/29360043/diff/29360044/packagerEdge.py#new...
packagerEdge.py:123: if ext and ext not in params['defaults']:
Rather than adding a special case here, note that you can just add a type to the
mimetypes API:

  types = mimetypes.MimeTypes()
  types.add_type('application/octet-stream', '.otf')
  ...
  content_type = types.guess_type(filename, strict=False)[0]

Initializing a local MimeTypes object isn't technically necessary, but avoids
side effects if other code is using the miemtypes module as well.

[Vasily Kuznetsov, 2016-11-30 15:11:46]

https://codereview.adblockplus.org/29360043/diff/29360044/packagerEdge.py
File packagerEdge.py (right):

https://codereview.adblockplus.org/29360043/diff/29360044/packagerEdge.py#new...
packagerEdge.py:117: '.otf': 'application/octet-stream',
On 2016/10/28 12:43:51, Sebastian Noack wrote:
> Why not using 'application/font-sfnt' or 'application/x-font-sfnt'?

'application/octet-stream' is what Microsoft and Facebook packagers output. I
thought being consistent with them is probably the safest way to go.

https://codereview.adblockplus.org/29360043/diff/29360044/packagerEdge.py#new...
packagerEdge.py:123: if ext and ext not in params['defaults']:
On 2016/10/28 12:43:51, Sebastian Noack wrote:
> Rather than adding a special case here, note that you can just add a type to
the
> mimetypes API:
> 
>   types = mimetypes.MimeTypes()
>   types.add_type('application/octet-stream', '.otf')
>   ...
>   content_type = types.guess_type(filename, strict=False)[0]
> 
> Initializing a local MimeTypes object isn't technically necessary, but avoids
> side effects if other code is using the miemtypes module as well.

You're right, this is better.

Done.

[Sebastian Noack, 2016-12-05 11:53:07]

LGTM