Issue 29361127: Issue 4587 - Blockable items list calls reloadDisabledFilters() unnecessarily often

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29361127: Issue 4587 - Blockable items list calls reloadDisabledFilters() unnecessarily often (Closed)

Created:
Oct. 31, 2016, 9:18 a.m. by Wladimir Palant

Modified:
Oct. 31, 2016, 12:20 p.m.

Reviewers:
kzar

Base URL:
https://hg.adblockplus.org/adblockplus

Visibility:
Public.

Description

Issue 4587 - Blockable items list calls reloadDisabledFilters() unnecessarily often

Patch Set 1 #

Created: Oct. 31, 2016, 9:18 a.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -2 lines)			Patch
	M	chrome/content/ui/sidebar.js	View		2 chunks	+14 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

kzar

LGTM (Maybe we should remove the other uses of the deprecated FilterNotifier.addListener while at it?)

Oct. 31, 2016, 11:24 a.m. (2016-10-31 11:24:43 UTC) #2

Wladimir Palant

Oct. 31, 2016, 12:20 p.m. (2016-10-31 12:20:07 UTC) #3

On 2016/10/31 11:24:43, kzar wrote:
> (Maybe we should remove the other uses of the deprecated
> FilterNotifier.addListener while at it?)

We certainly should, but at least sync.js is very hard to test.

Expand All Messages | Collapse All Messages