Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: libadblockplus-android-webviewapp/AndroidManifest.xml

Issue 29361445: Issue 4399 - Add WebView inheritor with ad blocking (Closed)
Patch Set: Created Nov. 1, 2016, 12:14 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: libadblockplus-android-webviewapp/AndroidManifest.xml
diff --git a/libadblockplus-android-webviewapp/AndroidManifest.xml b/libadblockplus-android-webviewapp/AndroidManifest.xml
new file mode 100644
index 0000000000000000000000000000000000000000..97cfc1ad7f8ed3d066483e41cb36b2f7b474448c
--- /dev/null
+++ b/libadblockplus-android-webviewapp/AndroidManifest.xml
@@ -0,0 +1,41 @@
+<?xml version="1.0" encoding="utf-8"?>
+<manifest xmlns:android="http://schemas.android.com/apk/res/android"
+ package="org.adblockplus.libadblockplus.android.webviewapp"
+ android:versionCode="1"
+ android:versionName="1.0">
+
+ <uses-sdk
+ android:minSdkVersion="17"
+ android:targetSdkVersion="21"/>
diegocarloslima 2016/11/08 16:30:56 Couldn't we target at least API 22?
+
+ <uses-permission android:name="android.permission.INTERNET"/>
+
+ <android:uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE"/>
+ <android:uses-permission android:name="android.permission.READ_PHONE_STATE"/>
+ <android:uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE"/>
diegocarloslima 2016/11/08 16:30:56 These 'uses-permission' elements with android name
anton 2016/11/09 12:30:42 Agee, they were added by IDE and to be honest i do
+
+ <application
+ android:icon="@drawable/icon"
+ android:name=".Application"
+ android:label="@string/app_name">
+
+ <!-- main -->
+ <activity
+ android:name=".MainActivity"
+ android:label="@string/app_name"
+ android:launchMode="singleTop">
+ <intent-filter>
+ <action android:name="android.intent.action.MAIN"/>
+
+ <category android:name="android.intent.category.LAUNCHER"/>
+ </intent-filter>
+ </activity>
+
+ <!-- settings -->
+ <activity
+ android:name=".SettingsActivity"
+ android:label="@string/settings_name"
+ android:theme="@android:style/Theme.DeviceDefault.Light"/>
+ </application>
+
+</manifest>

Powered by Google App Engine
This is Rietveld