Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29361543: Noissue - Clean code of JsContext (Closed)

Created:
Nov. 2, 2016, 10:54 a.m. by sergei
Modified:
Nov. 3, 2016, 9:09 a.m.
Reviewers:
Oleksandr
CC:
Felix Dahlke
Visibility:
Public.

Description

- make destructor non-virtual because no one inheriting from it, so it's only confusing. Remove new destructor because the same destructor is generated by the compiler. - make constructor explicit.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M src/JsContext.h View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 2
sergei
Nov. 2, 2016, 10:56 a.m. (2016-11-02 10:56:23 UTC) #1
Oleksandr
Nov. 2, 2016, 2:53 p.m. (2016-11-02 14:53:47 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld