Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29361779: Issue 4608 - Add local=True To Revision Property (Closed)

Created:
Nov. 7, 2016, 1:32 p.m. by Jon Sonesen
Modified:
Nov. 7, 2016, 1:58 p.m.
Visibility:
Public.

Description

Issue 4608 - Add local=True To Revision Property Repository: hg.adblockplus.org/sitescripts

Patch Set 1 #

Total comments: 2

Patch Set 2 : move to local properties #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M sitescripts/extensions/utils.py View 1 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 5
Jon Sonesen
Nov. 7, 2016, 1:32 p.m. (2016-11-07 13:32:09 UTC) #1
Wladimir Palant
https://codereview.adblockplus.org/29361779/diff/29361780/sitescripts/extensions/utils.py File sitescripts/extensions/utils.py (right): https://codereview.adblockplus.org/29361779/diff/29361780/sitescripts/extensions/utils.py#newcode145 sitescripts/extensions/utils.py:145: revision = _defineProperty('revision', local=True, default='master') Why did you put ...
Nov. 7, 2016, 1:33 p.m. (2016-11-07 13:33:25 UTC) #2
Jon Sonesen
https://codereview.adblockplus.org/29361779/diff/29361780/sitescripts/extensions/utils.py File sitescripts/extensions/utils.py (right): https://codereview.adblockplus.org/29361779/diff/29361780/sitescripts/extensions/utils.py#newcode145 sitescripts/extensions/utils.py:145: revision = _defineProperty('revision', local=True, default='master') On 2016/11/07 13:33:25, Wladimir ...
Nov. 7, 2016, 1:42 p.m. (2016-11-07 13:42:25 UTC) #3
Wladimir Palant
LGTM
Nov. 7, 2016, 1:50 p.m. (2016-11-07 13:50:12 UTC) #4
Sebastian Noack
Nov. 7, 2016, 1:50 p.m. (2016-11-07 13:50:50 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld