Issue 4608 - Add local=True To Revision Property

sitescripts/extensions/utils.py

Index: sitescripts/extensions/utils.py
===================================================================
--- a/sitescripts/extensions/utils.py
+++ b/sitescripts/extensions/utils.py
@@ -128,26 +128,26 @@
         """
         return property(lambda self: self.nightlyConfig.get(self.repositoryName, key),
                         lambda self, value: self.nightlyConfig.set(self.repositoryName, key, value))
 
     config = None
     nightlyConfig = None
     repositoryName = None
     repository = None
-    revision = _defineProperty('revision', default='master')
 
     spiderMonkeyBinary = _defineProperty('spiderMonkeyBinary', default='')
     nightliesDirectory = _defineProperty('nightliesDirectory')
     nightliesURL = _defineProperty('nightliesURL')
     downloadsRepo = _defineProperty('downloadsRepo')
     downloadsURL = _defineProperty('downloadsURL')
     docsDirectory = _defineProperty('docsDirectory')
     signtool = _defineProperty('signtool')
     certname = _defineProperty('signtool_certname')
+    revision = _defineProperty('revision', local=True, default='master')

[Wladimir Palant, 2016/11/07 13:33:25]

Why did you put it in the middle of global properties? Local properties are
further below - I'd expect to find this below the "name" property.

[Jon Sonesen, 2016/11/07 13:42:25]

Acknowledged.

     dbdir = _defineProperty('signtool_dbdir')
     dbpass = _defineProperty('signtool_dbpass')
 
     keyFile = _defineProperty('key', local=True, default='')
     name = _defineProperty('name', local=True)
     galleryID = _defineProperty('galleryID', local=True, default='')
     devbuildGalleryID = _defineProperty('devbuildGalleryID', local=True, default='')
     downloadPage = _defineProperty('downloadPage', local=True, default='')