Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29362492: Issue 3598 - Change the permission point in android FAQ page on [adblockbrowser.org] (Closed)

Created:
Nov. 11, 2016, 7:34 p.m. by juliandoucette
Modified:
May 4, 2017, 3:14 p.m.
Reviewers:
saroyanm
Base URL:
https://hg.adblockplus.org/web.adblockbrowser.org
Visibility:
Public.

Description

Issue 3598 - Change the permission point in android FAQ page on [adblockbrowser.org]

Patch Set 1 #

Total comments: 4

Patch Set 2 : Merged duplicate selectors #

Total comments: 2

Patch Set 3 : Fixed descriptions, fixed markdown to HTML conversion #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -6 lines) Patch
M pages/android-support/faq.html View 1 2 2 chunks +27 lines, -6 lines 0 comments Download

Messages

Total messages: 10
juliandoucette
Nov. 11, 2016, 7:34 p.m. (2016-11-11 19:34:16 UTC) #1
juliandoucette
On 2016/11/11 19:34:16, juliandoucette wrote: Should be a quick one.
Nov. 11, 2016, 7:34 p.m. (2016-11-11 19:34:41 UTC) #2
juliandoucette
> Should be a quick one. BUMP.
Jan. 24, 2017, 9:48 p.m. (2017-01-24 21:48:50 UTC) #3
saroyanm
Just, 2 small comments. https://codereview.adblockplus.org/29362492/diff/29362493/pages/android-support/faq.html File pages/android-support/faq.html (right): https://codereview.adblockplus.org/29362492/diff/29362493/pages/android-support/faq.html#newcode10 pages/android-support/faq.html:10: #faq dt This selector is ...
Jan. 31, 2017, 1:49 p.m. (2017-01-31 13:49:53 UTC) #4
juliandoucette
See question below. https://codereview.adblockplus.org/29362492/diff/29362493/pages/android-support/faq.html File pages/android-support/faq.html (right): https://codereview.adblockplus.org/29362492/diff/29362493/pages/android-support/faq.html#newcode10 pages/android-support/faq.html:10: #faq dt On 2017/01/31 13:49:53, saroyanm ...
April 3, 2017, 6:38 p.m. (2017-04-03 18:38:37 UTC) #5
saroyanm
Can you please upload rebased code separately please if it's not require a lot of ...
April 4, 2017, 9:20 a.m. (2017-04-04 09:20:27 UTC) #6
juliandoucette
On 2017/04/04 09:20:27, saroyanm wrote: > Can you please upload rebased code separately please if ...
April 4, 2017, 11:45 a.m. (2017-04-04 11:45:46 UTC) #7
saroyanm
LGTM after fixing a small detail. https://codereview.adblockplus.org/29362492/diff/29402574/pages/android-support/faq.html File pages/android-support/faq.html (right): https://codereview.adblockplus.org/29362492/diff/29402574/pages/android-support/faq.html#newcode32 pages/android-support/faq.html:32: <p>{{permissions-p-1[Permissions answer paragraph ...
April 28, 2017, 11:55 a.m. (2017-04-28 11:55:41 UTC) #8
juliandoucette
A few links were not working because I changed the format (md -> HTML). It's ...
April 28, 2017, 6:29 p.m. (2017-04-28 18:29:10 UTC) #9
saroyanm
May 2, 2017, 1:43 p.m. (2017-05-02 13:43:33 UTC) #10
LGTM

Powered by Google App Engine
This is Rietveld