Issue 29362492: Issue 3598 - Change the permission point in android FAQ page on [adblockbrowser.org] (Closed)
|
Created:
Nov. 11, 2016, 7:34 p.m. by juliandoucette Modified:
May 4, 2017, 3:14 p.m. Reviewers:
saroyanm Base URL:
https://hg.adblockplus.org/web.adblockbrowser.org Visibility:
Public. |
DescriptionIssue 3598 - Change the permission point in android FAQ page on [adblockbrowser.org]
Patch Set 1 #
Total comments: 4
Patch Set 2 : Merged duplicate selectors #
Total comments: 2
Patch Set 3 : Fixed descriptions, fixed markdown to HTML conversion #MessagesTotal messages: 10
On 2016/11/11 19:34:16, juliandoucette wrote: Should be a quick one.
> Should be a quick one. BUMP.
Just, 2 small comments. https://codereview.adblockplus.org/29362492/diff/29362493/pages/android-suppo... File pages/android-support/faq.html (right): https://codereview.adblockplus.org/29362492/diff/29362493/pages/android-suppo... pages/android-support/faq.html:10: #faq dt This selector is possible to merge with the one above. https://codereview.adblockplus.org/29362492/diff/29362493/pages/android-suppo... pages/android-support/faq.html:36: <p>{{permissions-p-1[Permissions answer paragraph 1] Generally, browsers require more permissions than regular apps to be able to provide web applications the ability to use hardware functionality such as camera, microphone, etc. (e.g. uploading images from your camera).}}</p> Let's not numerate the description, otherwise we will need to renumerate them if new paragraph added, for StringIDs fine for now, while we didn't resolve #4805.
See question below. https://codereview.adblockplus.org/29362492/diff/29362493/pages/android-suppo... File pages/android-support/faq.html (right): https://codereview.adblockplus.org/29362492/diff/29362493/pages/android-suppo... pages/android-support/faq.html:10: #faq dt On 2017/01/31 13:49:53, saroyanm wrote: > This selector is possible to merge with the one above. Done. https://codereview.adblockplus.org/29362492/diff/29362493/pages/android-suppo... pages/android-support/faq.html:36: <p>{{permissions-p-1[Permissions answer paragraph 1] Generally, browsers require more permissions than regular apps to be able to provide web applications the ability to use hardware functionality such as camera, microphone, etc. (e.g. uploading images from your camera).}}</p> On 2017/01/31 13:49:53, saroyanm wrote: > Let's not numerate the description, otherwise we will need to renumerate them if > new paragraph added, for StringIDs fine for now, while we didn't resolve #4805. It's not trivial to come up with unique and meaningful ids and descriptions based on content here. Why is this worth it?
Can you please upload rebased code separately please if it's not require a lot of effort ?
On 2017/04/04 09:20:27, saroyanm wrote: > Can you please upload rebased code separately please if it's not require a lot > of effort ? I was mistaken. I saw that this file applied to faq.html and there was only faq.md so I thought that it must have changed since I uploaded the first patch. But it didn't. This patch is supposed to include renaming faq.md to faq.html. If it doesn't then that is a mercurial and/or reitveld bug and you can get around it by renaming the file yourself before applying the patch.
LGTM after fixing a small detail. https://codereview.adblockplus.org/29362492/diff/29402574/pages/android-suppo... File pages/android-support/faq.html (right): https://codereview.adblockplus.org/29362492/diff/29402574/pages/android-suppo... pages/android-support/faq.html:32: <p>{{permissions-p-1[Permissions answer paragraph 1] Generally, browsers require more permissions than regular apps to be able to provide web applications the ability to use hardware functionality such as camera, microphone, etc. (e.g. uploading images from your camera).}}</p> Detail: As far as I remeber the decision was not to numerate descriptions. Same applies to all descriptions below.
A few links were not working because I changed the format (md -> HTML). It's worth making sure that these translations are still OK. https://codereview.adblockplus.org/29362492/diff/29402574/pages/android-suppo... File pages/android-support/faq.html (right): https://codereview.adblockplus.org/29362492/diff/29402574/pages/android-suppo... pages/android-support/faq.html:32: <p>{{permissions-p-1[Permissions answer paragraph 1] Generally, browsers require more permissions than regular apps to be able to provide web applications the ability to use hardware functionality such as camera, microphone, etc. (e.g. uploading images from your camera).}}</p> On 2017/04/28 11:55:40, saroyanm wrote: > Detail: As far as I remeber the decision was not to numerate descriptions. > > Same applies to all descriptions below. Done.
LGTM 
|
