Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29362515: Issue 4368 - Ignore whitelisted schemes for pop-ups (Closed)

Created:
Nov. 14, 2016, 12:48 p.m. by Wladimir Palant
Modified:
Nov. 14, 2016, 1:29 p.m.
Reviewers:
kzar
Base URL:
https://hg.adblockplus.org/adblockplus
Visibility:
Public.

Description

Normally we ignore data: and such because nothing is being downloaded, it`s merely page internals. For POPUP this is different however, so I am adding an exception for it.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M lib/contentPolicy.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2
Wladimir Palant
Nov. 14, 2016, 12:48 p.m. (2016-11-14 12:48:57 UTC) #1
kzar
Nov. 14, 2016, 1:22 p.m. (2016-11-14 13:22:23 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld