Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: lib/contentPolicy.js

Issue 29362515: Issue 4368 - Ignore whitelisted schemes for pop-ups (Closed) Base URL: https://hg.adblockplus.org/adblockplus
Patch Set: Created Nov. 14, 2016, 12:48 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/contentPolicy.js
===================================================================
--- a/lib/contentPolicy.js
+++ b/lib/contentPolicy.js
@@ -134,17 +134,17 @@ var Policy = exports.Policy =
}
function response(allow, collapse)
{
return {allow, collapse, hits};
}
// Ignore whitelisted schemes
- if (!this.isBlockableScheme(location))
+ if (contentType != "POPUP" && !this.isBlockableScheme(location))
return response(true, false);
// Interpret unknown types as "other"
contentType = this.contentTypes.get(contentType) || "OTHER";
let nogeneric = false;
if (Prefs.enabled)
{
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld