Unified Diff: templates/manifest.json.tmpl
Issue 29365583:
Issue 4670 - Add a new build type for Gecko-based WebExtensions (Closed)
Base URL: https://hg.adblockplus.org/buildtools
Patch Set: Updated the way options page is specified in the manifest
Created Nov. 30, 2016, 1:23 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« templates/chromeInfo.js.tmpl ('K')
|
« templates/chromeInfo.js.tmpl ('k')
|
no next file »
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: templates/manifest.json.tmpl |
| =================================================================== |
| --- a/templates/manifest.json.tmpl |
| +++ b/templates/manifest.json.tmpl |
| @@ -19,16 +19,30 @@ |
| {%- if metadata.has_section('compat') and metadata.has_option('compat', 'chrome') %} |
| "minimum_chrome_version": {{metadata.get('compat', 'chrome')|json}}, |
| {%- endif %} |
| {%- if metadata.has_section('compat') and metadata.has_option('compat', 'edge') %} |
| "minimum_edge_version": {{metadata.get('compat', 'edge')|json}}, |
| {%- endif %} |
| + {%- if type == 'gecko-webext' %} |
| + "applications": |
| + { |
| + "gecko": |
| + { |
| + "id": {{metadata.get('general', 'id')|json}} |
| + {%- if metadata.has_section('compat') and metadata.has_option('compat', 'gecko') %} |
|
Sebastian Noack
2016/12/01 16:24:54
If I understand correctly this will result into a
Wladimir Palant
2016/12/01 21:39:32
It doesn't matter because this JSON file is being
|
| + , |
| + "strict_min_version": {{metadata.get('compat', 'gecko')|json}} |
| + {%- endif %} |
| + } |
| + }, |
| + {%- endif %} |
| + |
| {%- if pageAction %} |
| "page_action": { |
| "default_icon": {{pageAction.icon|json}}, |
| {%- if pageAction.popup %} |
| "default_popup": {{pageAction.popup|json}}, |
| {%- endif %} |
| "default_title": "__MSG_name__" |
| }, |
| @@ -59,17 +73,20 @@ |
| {%- if backgroundScripts %} |
| "background": { |
| "scripts": {{backgroundScripts|json}}, |
| "persistent": true |
| }, |
| {%- endif %} |
| {%- if metadata.has_option('general', 'options') %} |
| - "options_page": {{metadata.get('general', 'options')|json}}, |
| + "options_ui": { |
|
Sebastian Noack
2016/12/01 16:24:54
Did you test whether this is supported on Microsof
Wladimir Palant
2016/12/01 21:39:31
You are right, it doesn't. So fallback it is.
|
| + "page": {{metadata.get('general', 'options')|json}}, |
| + "open_in_tab": true |
| + }, |
| {%- endif %} |
| {%- if metadata.has_option('general', 'devtools') %} |
| "devtools_page": {{metadata.get('general', 'devtools')|json}}, |
| {%- endif %} |
| {%- if contentScripts %} |
| "content_scripts": {{contentScripts|json}}, |
« templates/chromeInfo.js.tmpl ('K')
|
« templates/chromeInfo.js.tmpl ('k')
|
no next file »
|
no next file with comments »
