Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: README.md

Issue 29365879: Issue 4616 - Push Edge related changes to the edge bookmark of adblockpluschrome (Closed)
Patch Set: Add appropriate icons Created Dec. 1, 2016, 11:37 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | icons/abp-44.png » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: README.md
===================================================================
--- a/README.md
+++ b/README.md
@@ -24,9 +24,11 @@
./build.py -t chrome build -k adblockpluschrome.pem
./build.py -t safari build -k adblockplussafari.pem
+ ./build.py -t edge build
This will create a build with a name in the form
-_adblockpluschrome-1.2.3.nnnn.crx_ or _adblockplussafari-1.2.3.nnnn.safariextz_.
+_adblockpluschrome-1.2.3.nnnn.crx_ or _adblockplussafari-1.2.3.nnnn.safariextz_
kzar 2016/12/01 12:11:01 Nit: The second "or" should now be a comma I guess
Oleksandr 2016/12/01 14:18:04 Isn't it better with first "or" changed to comma?
kzar 2016/12/01 14:23:06 Yes, whoops that's what I meant.
+or adblockplusedge-1.2.3.nnnn.appx.
Note that you don't need an existing signing key for Chrome, a new key
will be created automatically if the file doesn't exist. Safari on the other
hand always requires a valid developer certificate, you need to get one in the
@@ -54,6 +56,9 @@
extension explicitly in the Extension Builder, Safari currently doesn't allow
automating this action.
+In Edge you should load _devenv.chrome as unpacked extension directory. After
kzar 2016/12/01 12:11:01 I think this paragraph should be above the Safari
kzar 2016/12/01 12:11:01 Nit: Missing the underscore after "devenv.chrome".
Oleksandr 2016/12/01 14:18:04 Done.
Oleksandr 2016/12/01 14:18:04 Done.
+rebuilding the extension you should usually force reloading it in Edge.
+
Running the unit tests
----------------------
« no previous file with comments | « no previous file | icons/abp-44.png » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld