Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29366552: Issue 2879 - Make "view source" command work again (Closed)

Created:
Dec. 1, 2016, 10:49 a.m. by Wladimir Palant
Modified:
Dec. 20, 2016, 3:08 p.m.
Reviewers:
saroyanm
Base URL:
https://hg.adblockplus.org/elemhidehelper
Visibility:
Public.

Description

I removed CDATA handling while at it, this node type is definitely irrelevant for HTML documents by now.

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -83 lines) Patch
M lib/aardvark.js View 1 3 chunks +91 lines, -83 lines 0 comments Download
M lib/child/commands.js View 1 chunk +44 lines, -0 lines 0 comments Download

Messages

Total messages: 4
Wladimir Palant
Dec. 1, 2016, 10:49 a.m. (2016-12-01 10:49:48 UTC) #1
saroyanm
LGTM with just 2 small comments. https://codereview.adblockplus.org/29366552/diff/29366553/lib/aardvark.js File lib/aardvark.js (right): https://codereview.adblockplus.org/29366552/diff/29366553/lib/aardvark.js#newcode388 lib/aardvark.js:388: this.appendDescription(startTag, '"' + ...
Dec. 5, 2016, 5:51 p.m. (2016-12-05 17:51:47 UTC) #2
Wladimir Palant
https://codereview.adblockplus.org/29366552/diff/29366553/lib/aardvark.js File lib/aardvark.js (right): https://codereview.adblockplus.org/29366552/diff/29366553/lib/aardvark.js#newcode388 lib/aardvark.js:388: this.appendDescription(startTag, '"' + value.replace(/"/, """) + '"', "attrValue"); On ...
Dec. 8, 2016, 1:11 p.m. (2016-12-08 13:11:29 UTC) #3
saroyanm
Dec. 20, 2016, 2:32 p.m. (2016-12-20 14:32:13 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld