Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(102)

Issue 29366570: Issue 4681 - Move URL Fixer first-run page into the extension (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 2 months ago by Wladimir Palant
Modified:
2 years, 10 months ago
Reviewers:
Thomas Greiner
Base URL:
https://hg.adblockplus.org/urlfixer
Visibility:
Public.

Description

Issue 4681 - Move URL Fixer first-run page into the extension

Patch Set 1 : #

Total comments: 11

Patch Set 2 : Updated license #

Unified diffs Side-by-side diffs Delta from patch set Stats (+631 lines, -1 line) Patch
A chrome/content/firstrun/designosaur-regular-webfont.woff View Binary file 0 comments Download
A chrome/content/firstrun/fancybox/blank.gif View Binary file 0 comments Download
A chrome/content/firstrun/fancybox/fancy_close.png View Binary file 0 comments Download
A chrome/content/firstrun/fancybox/fancy_loading.png View Binary file 0 comments Download
A chrome/content/firstrun/fancybox/fancy_nav_left.png View Binary file 0 comments Download
A chrome/content/firstrun/fancybox/fancy_nav_right.png View Binary file 0 comments Download
A chrome/content/firstrun/fancybox/fancy_shadow_e.png View Binary file 0 comments Download
A chrome/content/firstrun/fancybox/fancy_shadow_n.png View Binary file 0 comments Download
A chrome/content/firstrun/fancybox/fancy_shadow_ne.png View Binary file 0 comments Download
A chrome/content/firstrun/fancybox/fancy_shadow_nw.png View Binary file 0 comments Download
A chrome/content/firstrun/fancybox/fancy_shadow_s.png View Binary file 0 comments Download
A chrome/content/firstrun/fancybox/fancy_shadow_se.png View Binary file 0 comments Download
A chrome/content/firstrun/fancybox/fancy_shadow_sw.png View Binary file 0 comments Download
A chrome/content/firstrun/fancybox/fancy_shadow_w.png View Binary file 0 comments Download
A chrome/content/firstrun/fancybox/fancy_title_left.png View Binary file 0 comments Download
A chrome/content/firstrun/fancybox/fancy_title_main.png View Binary file 0 comments Download
A chrome/content/firstrun/fancybox/fancy_title_over.png View Binary file 0 comments Download
A chrome/content/firstrun/fancybox/fancy_title_right.png View Binary file 0 comments Download
A chrome/content/firstrun/fancybox/fancybox.png View Binary file 0 comments Download
A chrome/content/firstrun/fancybox/fancybox-x.png View Binary file 0 comments Download
A chrome/content/firstrun/fancybox/fancybox-y.png View Binary file 0 comments Download
A chrome/content/firstrun/fancybox/jquery.fancybox-1.3.4.css View 1 chunk +360 lines, -0 lines 0 comments Download
A chrome/content/firstrun/fancybox/jquery.fancybox-1.3.4.pack.js View 1 chunk +46 lines, -0 lines 0 comments Download
A chrome/content/firstrun/index.html View 1 1 chunk +115 lines, -0 lines 0 comments Download
A chrome/content/firstrun/jquery-1.7.1.min.js View 1 chunk +4 lines, -0 lines 0 comments Download
A chrome/content/firstrun/logo.png View Binary file 0 comments Download
A chrome/content/firstrun/reset.css View 1 chunk +54 lines, -0 lines 0 comments Download
A chrome/content/firstrun/screenshot2.png View Binary file 0 comments Download
A chrome/content/firstrun/screenshot2-big.png View Binary file 0 comments Download
A chrome/content/firstrun/screenshot3.png View Binary file 0 comments Download
A chrome/content/firstrun/screenshot3-big.png View Binary file 0 comments Download
A chrome/content/firstrun/screenshot4.png View Binary file 0 comments Download
A chrome/content/firstrun/screenshot4-big.png View Binary file 0 comments Download
A chrome/content/firstrun/style.css View 1 chunk +51 lines, -0 lines 0 comments Download
M lib/main.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
Wladimir Palant
Not as bad as it looks - there aren't actually many changes here. It's mostly ...
3 years, 2 months ago (2016-12-01 13:13:44 UTC) #1
Thomas Greiner
All the changes seem reasonable. There's just one small comment I added. https://codereview.adblockplus.org/29366570/diff/29366607/chrome/content/firstrun/fancybox/jquery.fancybox-1.3.4.css File chrome/content/firstrun/fancybox/jquery.fancybox-1.3.4.css ...
3 years, 2 months ago (2016-12-07 16:08:32 UTC) #2
Wladimir Palant
https://codereview.adblockplus.org/29366570/diff/29366607/chrome/content/firstrun/index.html File chrome/content/firstrun/index.html (right): https://codereview.adblockplus.org/29366570/diff/29366607/chrome/content/firstrun/index.html#newcode107 chrome/content/firstrun/index.html:107: Open-source software released under <a href="http://www.mozilla.org/MPL/1.1/">Mozilla Public License</a> On ...
3 years, 2 months ago (2016-12-08 13:02:23 UTC) #3
Thomas Greiner
3 years, 2 months ago (2016-12-08 14:25:19 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5