Unified Diff: stats.js
Issue 29366773:
Issue 4698 - Popup window is broken in Edge (Closed)
Patch Set:
Created Dec. 5, 2016, 12:15 a.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« chrome/ext/popup.js ('k')
|
no next file »
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: stats.js |
| =================================================================== |
| --- a/stats.js |
| +++ b/stats.js |
| @@ -96,11 +96,11 @@ |
| { |
| var statsPage = document.getElementById("stats-page"); |
| var blockedPage = getBlockedPerPage(currentPage).toLocaleString(); |
| - i18n.setElementText(statsPage, "stats_label_page", [blockedPage]); |
| + i18n.setElementText(statsPage, "stats_label_page", blockedPage); |
|
Oleksandr
2016/12/05 00:27:36
Edge throws if passed an array as a second paramet
kzar
2016/12/05 12:22:52
How come that throws, since according to the Mozil
|
| var statsTotal = document.getElementById("stats-total"); |
| var blockedTotal = Prefs.blocked_total.toLocaleString(); |
| - i18n.setElementText(statsTotal, "stats_label_total", [blockedTotal]); |
| + i18n.setElementText(statsTotal, "stats_label_total", blockedTotal); |
| } |
| function share(ev) |
« no previous file with comments
|
« chrome/ext/popup.js ('k')
|
no next file »
|
no next file with comments »
