Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(253)

Issue 29366791: Issue 4699 - Edge does not support 16px and 32px icons (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 9 months ago by Oleksandr
Modified:
2 years, 9 months ago
Visibility:
Public.

Description

Issue 4699 - Edge does not support 16px and 32px icons

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -30 lines) Patch
M chrome/ext/background.js View 3 chunks +32 lines, -30 lines 2 comments Download

Messages

Total messages: 4
Oleksandr
2 years, 9 months ago (2016-12-05 05:27:27 UTC) #1
Oleksandr
https://codereview.adblockplus.org/29366791/diff/29366792/chrome/ext/background.js File chrome/ext/background.js (left): https://codereview.adblockplus.org/29366791/diff/29366792/chrome/ext/background.js#oldcode229 chrome/ext/background.js:229: this._legacySetIcon(details); In this case, the `this` pointer is refreshed ...
2 years, 9 months ago (2016-12-05 05:29:59 UTC) #2
kzar
The icon animation code is already a mess and I fear this change would make ...
2 years, 9 months ago (2016-12-05 16:17:56 UTC) #3
Wladimir Palant
2 years, 9 months ago (2016-12-08 13:16:47 UTC) #4
On 2016/12/05 16:17:56, kzar wrote:
> Wladimir any idea what resolution icons Firefox WebExtensions will expect?

Firefox expects 16px and 32px.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5