Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29366791: Issue 4699 - Edge does not support 16px and 32px icons (Closed)

Created:
Dec. 5, 2016, 5:25 a.m. by Oleksandr
Modified:
Dec. 13, 2016, 3:54 a.m.
Visibility:
Public.

Description

Issue 4699 - Edge does not support 16px and 32px icons

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -30 lines) Patch
M chrome/ext/background.js View 3 chunks +32 lines, -30 lines 2 comments Download

Messages

Total messages: 4
Oleksandr
Dec. 5, 2016, 5:27 a.m. (2016-12-05 05:27:27 UTC) #1
Oleksandr
https://codereview.adblockplus.org/29366791/diff/29366792/chrome/ext/background.js File chrome/ext/background.js (left): https://codereview.adblockplus.org/29366791/diff/29366792/chrome/ext/background.js#oldcode229 chrome/ext/background.js:229: this._legacySetIcon(details); In this case, the `this` pointer is refreshed ...
Dec. 5, 2016, 5:29 a.m. (2016-12-05 05:29:59 UTC) #2
kzar
The icon animation code is already a mess and I fear this change would make ...
Dec. 5, 2016, 4:17 p.m. (2016-12-05 16:17:56 UTC) #3
Wladimir Palant
Dec. 8, 2016, 1:16 p.m. (2016-12-08 13:16:47 UTC) #4
On 2016/12/05 16:17:56, kzar wrote:
> Wladimir any idea what resolution icons Firefox WebExtensions will expect?

Firefox expects 16px and 32px.

Powered by Google App Engine
This is Rietveld