Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29366857: Issue 4705 - Adjust update server configuration for new Gecko update manifest format (Closed)

Created:
Dec. 5, 2016, 12:42 p.m. by Wladimir Palant
Modified:
Dec. 6, 2016, 11:33 a.m.
Reviewers:
f.nicolaisen
CC:
mathias
Base URL:
https://hg.adblockplus.org/infrastructure
Visibility:
Public.

Description

Issue 4705 - Adjust update server configuration for new Gecko update manifest format

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M modules/updateserver/files/sitescripts View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5
Wladimir Palant
Dec. 5, 2016, 12:42 p.m. (2016-12-05 12:42:40 UTC) #1
f.nicolaisen
Disclaimer: not familiar with the sitescripts, so I can only review superficially. Note that there ...
Dec. 6, 2016, 10:52 a.m. (2016-12-06 10:52:40 UTC) #2
Wladimir Palant
On 2016/12/06 10:52:40, f.nicolaisen wrote: > Note that there is a reference to the update.rdf ...
Dec. 6, 2016, 11:17 a.m. (2016-12-06 11:17:41 UTC) #3
f.nicolaisen
On 2016/12/06 11:17:41, Wladimir Palant wrote: > On 2016/12/06 10:52:40, f.nicolaisen wrote: > > Note ...
Dec. 6, 2016, 11:18 a.m. (2016-12-06 11:18:52 UTC) #4
Wladimir Palant
Dec. 6, 2016, 11:33 a.m. (2016-12-06 11:33:29 UTC) #5
Message was sent while issue was closed.
On 2016/12/06 11:18:52, f.nicolaisen wrote:
> Can that redirect then be removed in the same commit?

Nope, I'd rather not go there. Technically, update.rdf still exists on the
update server. And at some point we'll probably want to clean it all up so that
we only host update manifests for self-hosted products - this will mean removing
updates.json as well.

Powered by Google App Engine
This is Rietveld