Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(232)

Issue 29366993: Issue 4629 - Default website boilerplate (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 9 months ago by juliandoucette
Modified:
2 years, 2 months ago
Reviewers:
Lisa, saroyanm, ire
Visibility:
Public.

Description

We would like to implement a default website boilerplate that developers can use as a starting point for new website implementations. COLLABORATOR=i.aderinokun@eyeo.com

Patch Set 1 #

Total comments: 24
Unified diffs Side-by-side diffs Delta from patch set Stats (+221 lines, -0 lines) Patch
A .hgignore View 1 chunk +2 lines, -0 lines 0 comments Download
A globals/site.py View 1 chunk +22 lines, -0 lines 0 comments Download
A gulpfile.js View 1 chunk +36 lines, -0 lines 4 comments Download
A package.json View 1 chunk +10 lines, -0 lines 0 comments Download
A pages/index.md View 1 chunk +62 lines, -0 lines 0 comments Download
A settings.ini View 1 chunk +3 lines, -0 lines 0 comments Download
A static/scss/main.scss View 1 chunk +19 lines, -0 lines 2 comments Download
A templates/default.tmpl View 1 chunk +67 lines, -0 lines 18 comments Download

Messages

Total messages: 7
juliandoucette
2 years, 9 months ago (2016-12-07 13:29:02 UTC) #1
juliandoucette
On 2016/12/07 13:29:02, juliandoucette wrote: @Manvel here is a first draft of the boilerplate including ...
2 years, 9 months ago (2016-12-07 13:39:29 UTC) #2
saroyanm
https://codereview.adblockplus.org/29366993/diff/29366994/gulpfile.js File gulpfile.js (right): https://codereview.adblockplus.org/29366993/diff/29366994/gulpfile.js#newcode31 gulpfile.js:31: gulp.watch("static/scss/*.scss", ["scss"]); Getting current error: Error: watch /home/saroyanm/projects/abp/websites/website-defaults/boilerplate/static/scss/ ENOSPC ...
2 years, 8 months ago (2017-01-11 12:04:41 UTC) #3
juliandoucette
I added these notes a while ago but I was unable to publish them because ...
2 years, 6 months ago (2017-03-03 11:17:44 UTC) #4
ire
My initial comments https://codereview.adblockplus.org/29366993/diff/29366994/gulpfile.js File gulpfile.js (right): https://codereview.adblockplus.org/29366993/diff/29366994/gulpfile.js#newcode31 gulpfile.js:31: gulp.watch("static/scss/*.scss", ["scss"]); This should watch `static/scss/**/*.scss` ...
2 years, 2 months ago (2017-06-22 16:14:25 UTC) #5
juliandoucette
Sorry Ire - I should have noted that this is not ready for review. There ...
2 years, 2 months ago (2017-06-22 18:23:52 UTC) #6
ire
2 years, 2 months ago (2017-06-23 07:23:32 UTC) #7
Message was sent while issue was closed.
On 2017/06/22 18:23:52, juliandoucette wrote:
> Sorry Ire - I should have noted that this is not ready for review. There is
> another version of this project here
https://gitlab.com/eyeo/website-boilerplate
> that we will build upon in the future. I'm going to close this review now and
> open new issues to add on the new boilerplate linked in the future.

Okay, I'll have a look at the gitlab repo
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5