Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(209)

Issue 29367145: Issue 4719 - Edge packager does not generate an info module (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 12 months ago by Oleksandr
Modified:
2 years, 11 months ago
Visibility:
Public.

Description

Issue 4719 - Edge packager does not generate an info module

Patch Set 1 #

Patch Set 2 : Rebase and fix the style #

Total comments: 4

Patch Set 3 : Add a test. Reformat code. #

Total comments: 1

Patch Set 4 : Remove the redundant whitespace. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M packagerEdge.py View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M tests/metadata.edge View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M tests/test_packagerEdge.py View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11
Oleksandr
2 years, 12 months ago (2016-12-09 06:17:38 UTC) #1
Vasily Kuznetsov
Please note that this change breaks the tests (more specifically the code style check): $ ...
2 years, 12 months ago (2016-12-09 11:46:23 UTC) #2
kzar
Once style issues Vasily pointed out are fixed LGTM
2 years, 11 months ago (2016-12-12 12:14:09 UTC) #3
Oleksandr
2 years, 11 months ago (2016-12-13 04:28:13 UTC) #4
kzar
https://codereview.adblockplus.org/29367145/diff/29367277/packagerEdge.py File packagerEdge.py (right): https://codereview.adblockplus.org/29367145/diff/29367277/packagerEdge.py#newcode175 packagerEdge.py:175: 'lib/info.js' in metadata.get('general', 'backgroundScripts').split() IMO this looks kind of ...
2 years, 11 months ago (2016-12-13 09:19:22 UTC) #5
Vasily Kuznetsov
https://codereview.adblockplus.org/29367145/diff/29367277/packagerEdge.py File packagerEdge.py (right): https://codereview.adblockplus.org/29367145/diff/29367277/packagerEdge.py#newcode175 packagerEdge.py:175: 'lib/info.js' in metadata.get('general', 'backgroundScripts').split() On 2016/12/13 09:19:22, kzar wrote: ...
2 years, 11 months ago (2016-12-13 18:49:59 UTC) #6
Sebastian Noack
https://codereview.adblockplus.org/29367145/diff/29367277/packagerEdge.py File packagerEdge.py (right): https://codereview.adblockplus.org/29367145/diff/29367277/packagerEdge.py#newcode175 packagerEdge.py:175: 'lib/info.js' in metadata.get('general', 'backgroundScripts').split() On 2016/12/13 18:49:58, Vasily Kuznetsov ...
2 years, 11 months ago (2016-12-15 13:58:06 UTC) #7
Oleksandr
https://codereview.adblockplus.org/29367145/diff/29367277/packagerEdge.py File packagerEdge.py (right): https://codereview.adblockplus.org/29367145/diff/29367277/packagerEdge.py#newcode175 packagerEdge.py:175: 'lib/info.js' in metadata.get('general', 'backgroundScripts').split() On 2016/12/15 13:58:06, Sebastian Noack ...
2 years, 11 months ago (2016-12-22 02:53:24 UTC) #8
Sebastian Noack
https://codereview.adblockplus.org/29367145/diff/29369496/tests/metadata.edge File tests/metadata.edge (right): https://codereview.adblockplus.org/29367145/diff/29369496/tests/metadata.edge#newcode20 tests/metadata.edge:20: It seems you accidentally added a blank line here.
2 years, 11 months ago (2016-12-22 15:24:12 UTC) #9
Oleksandr
2 years, 11 months ago (2016-12-22 16:25:52 UTC) #10
Sebastian Noack
2 years, 11 months ago (2016-12-22 16:30:49 UTC) #11
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5