Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(962)

Issue 29367316: Issue 4722 - Drop support for Chrome 41 - 48 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 11 months ago by kzar
Modified:
2 years, 11 months ago
Visibility:
Public.

Description

Issue 4722 - Drop support for Chrome 41 - 48

Patch Set 1 #

Patch Set 2 : Removed some legacy code #

Total comments: 14

Patch Set 3 : Brought back http CSP comment + indistinguishableTypes #

Patch Set 4 : Removed getIndistinguishableTypes function #

Total comments: 2

Patch Set 5 : Addressed nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -196 lines) Patch
M chrome/ext/background.js View 1 3 3 chunks +4 lines, -71 lines 0 comments Download
M include.preload.js View 1 2 chunks +6 lines, -9 lines 0 comments Download
M lib/csp.js View 1 2 1 chunk +3 lines, -5 lines 0 comments Download
M lib/icon.js View 1 1 chunk +1 line, -1 line 0 comments Download
D lib/polyfills/fetch.js View 1 1 chunk +0 lines, -75 lines 0 comments Download
M lib/requestBlocker.js View 1 2 3 4 1 chunk +2 lines, -5 lines 0 comments Download
M metadata.chrome View 1 chunk +1 line, -1 line 0 comments Download
M metadata.common View 1 1 chunk +1 line, -2 lines 0 comments Download
M options.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M options.js View 1 1 chunk +1 line, -6 lines 0 comments Download
M subscriptionLink.postload.js View 1 3 chunks +5 lines, -20 lines 0 comments Download

Messages

Total messages: 15
kzar
Patch Set 1
2 years, 11 months ago (2016-12-13 10:55:48 UTC) #1
Sebastian Noack
Generally, we also strip all obvious legacy code when advancing the minimum Chrome version. I've ...
2 years, 11 months ago (2016-12-13 11:09:12 UTC) #2
kzar
Patch Set 2 : Removed some legacy code > Mind stripping that code while on ...
2 years, 11 months ago (2016-12-13 13:59:44 UTC) #3
Wladimir Palant
https://codereview.adblockplus.org/29367316/diff/29367322/chrome/ext/background.js File chrome/ext/background.js (left): https://codereview.adblockplus.org/29367316/diff/29367322/chrome/ext/background.js#oldcode467 chrome/ext/background.js:467: return [["OBJECT", "OBJECT_SUBREQUEST"], otherTypes]; OBJECT and OBJECT_SUBREQUEST are still ...
2 years, 11 months ago (2016-12-13 14:15:02 UTC) #4
Sebastian Noack
https://codereview.adblockplus.org/29367316/diff/29367322/chrome/ext/background.js File chrome/ext/background.js (left): https://codereview.adblockplus.org/29367316/diff/29367322/chrome/ext/background.js#oldcode467 chrome/ext/background.js:467: return [["OBJECT", "OBJECT_SUBREQUEST"], otherTypes]; On 2016/12/13 14:15:02, Wladimir Palant ...
2 years, 11 months ago (2016-12-13 14:35:39 UTC) #5
Wladimir Palant
https://codereview.adblockplus.org/29367316/diff/29367322/chrome/ext/background.js File chrome/ext/background.js (left): https://codereview.adblockplus.org/29367316/diff/29367322/chrome/ext/background.js#oldcode467 chrome/ext/background.js:467: return [["OBJECT", "OBJECT_SUBREQUEST"], otherTypes]; On 2016/12/13 14:35:39, Sebastian Noack ...
2 years, 11 months ago (2016-12-13 14:46:35 UTC) #6
kzar
Patch Set 3 : Brought back http CSP comment + indistinguishableTypes https://codereview.adblockplus.org/29367316/diff/29367322/chrome/ext/background.js File chrome/ext/background.js (left): ...
2 years, 11 months ago (2016-12-13 15:05:40 UTC) #7
Sebastian Noack
https://codereview.adblockplus.org/29367316/diff/29367322/chrome/ext/background.js File chrome/ext/background.js (left): https://codereview.adblockplus.org/29367316/diff/29367322/chrome/ext/background.js#oldcode467 chrome/ext/background.js:467: return [["OBJECT", "OBJECT_SUBREQUEST"], otherTypes]; On 2016/12/13 14:46:35, Wladimir Palant ...
2 years, 11 months ago (2016-12-13 15:06:58 UTC) #8
kzar
https://codereview.adblockplus.org/29367316/diff/29367322/chrome/ext/background.js File chrome/ext/background.js (left): https://codereview.adblockplus.org/29367316/diff/29367322/chrome/ext/background.js#oldcode467 chrome/ext/background.js:467: return [["OBJECT", "OBJECT_SUBREQUEST"], otherTypes]; On 2016/12/13 15:06:58, Sebastian Noack ...
2 years, 11 months ago (2016-12-13 15:12:54 UTC) #9
Sebastian Noack
https://codereview.adblockplus.org/29367316/diff/29367322/chrome/ext/background.js File chrome/ext/background.js (left): https://codereview.adblockplus.org/29367316/diff/29367322/chrome/ext/background.js#oldcode467 chrome/ext/background.js:467: return [["OBJECT", "OBJECT_SUBREQUEST"], otherTypes]; On 2016/12/13 15:12:54, kzar wrote: ...
2 years, 11 months ago (2016-12-14 12:39:53 UTC) #10
kzar
Patch Set 4 : Removed getIndistinguishableTypes function https://codereview.adblockplus.org/29367316/diff/29367322/chrome/ext/background.js File chrome/ext/background.js (left): https://codereview.adblockplus.org/29367316/diff/29367322/chrome/ext/background.js#oldcode467 chrome/ext/background.js:467: return [["OBJECT", ...
2 years, 11 months ago (2016-12-16 09:38:35 UTC) #11
Wladimir Palant
https://codereview.adblockplus.org/29367316/diff/29368658/lib/requestBlocker.js File lib/requestBlocker.js (right): https://codereview.adblockplus.org/29367316/diff/29368658/lib/requestBlocker.js#newcode32 lib/requestBlocker.js:32: // Chrome can not distinguish between OBJECT_SUBREQUEST and OBJECT ...
2 years, 11 months ago (2016-12-16 10:06:15 UTC) #12
kzar
Patch Set 5 : Addressed nit https://codereview.adblockplus.org/29367316/diff/29368658/lib/requestBlocker.js File lib/requestBlocker.js (right): https://codereview.adblockplus.org/29367316/diff/29368658/lib/requestBlocker.js#newcode32 lib/requestBlocker.js:32: // Chrome can ...
2 years, 11 months ago (2016-12-16 10:27:35 UTC) #13
Wladimir Palant
No issues as far as I am concerned but this is really up to Sebastian.
2 years, 11 months ago (2016-12-16 10:34:09 UTC) #14
Sebastian Noack
2 years, 11 months ago (2016-12-16 11:08:45 UTC) #15
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5