Issue 4371 - Improving language on adblockplus.org

Issue 4371 - Improving language on adblockplus.org/en/subscriptions

[ire, 2017-05-23 14:16:58]

On 2017/05/22 12:00:33, saroyanm wrote:

LGTM

[juliandoucette, 2017-05-23 15:16:53]

LGTM

@Tamara do you want us to delay pushing this change until we have updated
translations?

[tamara, 2017-05-23 15:41:30]

On 2017/05/23 15:16:53, juliandoucette wrote:
> LGTM
> 
> @Tamara do you want us to delay pushing this change until we have updated
> translations?

I actually didn't request the translations for this text yet. I'll need to
gather all information first to send it to the agency.

In the meantime, maybe we can update the English text while we keep the current
translations as they are on Crowdin by using "update_without_changes". That is,
of course, if the new text hasn't been added as new IDs as it looks like in the
diff. :-/ Would that be an option until I have the translations or would you
rather wait until then to update the English?

[juliandoucette, 2017-05-24 11:52:27]

> Would that be an option until I have the translations or would you rather wait
until then to update the English?

That would be an option. We can push this now and sync translations on your
command.

[tamara, 2017-05-24 13:29:36]

On 2017/05/24 11:52:27, juliandoucette wrote:
> > Would that be an option until I have the translations or would you rather
wait
> until then to update the English?
> 
> That would be an option. We can push this now and sync translations on your
> command.

Ok. Can you confirm first, please, if the second and third string are being
updated with new IDs? Unfortunately, if that is the case, any translation that
was submitted previously will be deleted as the string IDs they were done for
will no longer exist. Does this make sense?

[juliandoucette, 2017-05-24 17:28:28]

> Ok. Can you confirm first, please, if the second and third string are being
> updated with new IDs? Unfortunately, if that is the case, any translation that
> was submitted previously will be deleted as the string IDs they were done for
> will no longer exist. Does this make sense?

I can confirm that no ids are changed, added, or removed.

[tamara, 2017-05-29 10:02:08]

On 2017/05/24 17:28:28, juliandoucette wrote:
> > Ok. Can you confirm first, please, if the second and third string are being
> > updated with new IDs? Unfortunately, if that is the case, any translation
that
> > was submitted previously will be deleted as the string IDs they were done
for
> > will no longer exist. Does this make sense?
> 
> I can confirm that no ids are changed, added, or removed.

Sorry for my delay, had Friday off.

Ok, that's cool. Then I will approve the current translations on Crowdin and
will let you know once they're done so you can update the English source.

[tamara, 2017-06-01 15:58:17]

@Julian

Turns out that when the ticket was created, there was no specification yet as to
how the company's name would be. Considering that it's been decided for branding
purposes that it'll be "eyeo", the two instances in the text where the company
is mentioned should therefore be corrected.

[ire, 2017-06-01 16:58:33]

On 2017/06/01 15:58:17, tamara wrote:
> Turns out that when the ticket was created, there was no specification yet as
to
> how the company's name would be. Considering that it's been decided for
branding
> purposes that it'll be "eyeo", the two instances in the text where the company
> is mentioned should therefore be corrected.

Thanks Tamara. Please can you update the Issue with the text as it should be,
then I'll upload a patch with the change.

[tamara, 2017-06-02 11:26:28]

On 2017/06/01 16:58:33, ire wrote:
> On 2017/06/01 15:58:17, tamara wrote:
> > Turns out that when the ticket was created, there was no specification yet
as
> to
> > how the company's name would be. Considering that it's been decided for
> branding
> > purposes that it'll be "eyeo", the two instances in the text where the
company
> > is mentioned should therefore be corrected.
> 
> Thanks Tamara. Please can you update the Issue with the text as it should be,
> then I'll upload a patch with the change.

Done!  ^^

[ire, 2017-06-05 11:02:11]

On 2017/06/02 11:26:28, tamara wrote:
> Done!  ^^

Thanks! And I meant to say that erick will upload a patch with the change :)

[juliandoucette, 2017-08-09 13:09:14]

I pushed this for Erick and synced translations. I'll wait until translations
are ready and pushed before closing this review.