Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29370627: Issue 4733 - Refactor nginx module (Closed)

Created:
Jan. 2, 2017, 11:46 p.m. by f.lopez
Modified:
Jan. 4, 2017, 9:10 p.m.
Reviewers:
Fred, f.nicolaisen
CC:
mathias
Visibility:
Public.

Description

Issue 4733 - Refactor nginx module Please push this as matze since he is on vacation and this has been tested several times over the last week!

Patch Set 1 #

Total comments: 2

Patch Set 2 : For comment #2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -16 lines) Patch
M Vagrantfile View 1 chunk +1 line, -1 line 0 comments Download
M modules/nginx/manifests/init.pp View 1 1 chunk +34 lines, -15 lines 0 comments Download
A modules/nginx/templates/apt.key.erb View 1 chunk +106 lines, -0 lines 0 comments Download

Messages

Total messages: 6
f.lopez
Jan. 2, 2017, 11:46 p.m. (2017-01-02 23:46:37 UTC) #1
Fred
https://codereview.adblockplus.org/29370627/diff/29370628/modules/nginx/manifests/init.pp File modules/nginx/manifests/init.pp (right): https://codereview.adblockplus.org/29370627/diff/29370628/modules/nginx/manifests/init.pp#newcode46 modules/nginx/manifests/init.pp:46: location => 'http://nginx.org/packages/mainline/debian/', Since we added "apt-transport-https" in the ...
Jan. 3, 2017, 3:09 p.m. (2017-01-03 15:09:46 UTC) #2
f.lopez
https://codereview.adblockplus.org/29370627/diff/29370628/modules/nginx/manifests/init.pp File modules/nginx/manifests/init.pp (right): https://codereview.adblockplus.org/29370627/diff/29370628/modules/nginx/manifests/init.pp#newcode46 modules/nginx/manifests/init.pp:46: location => 'http://nginx.org/packages/mainline/debian/', On 2017/01/03 15:09:46, Fred wrote: > ...
Jan. 3, 2017, 4:34 p.m. (2017-01-03 16:34:24 UTC) #3
f.lopez
Jan. 3, 2017, 4:35 p.m. (2017-01-03 16:35:14 UTC) #4
Fred
LGTM
Jan. 3, 2017, 4:58 p.m. (2017-01-03 16:58:09 UTC) #5
f.nicolaisen
Jan. 4, 2017, 5:28 p.m. (2017-01-04 17:28:22 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld