Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29370746: Issue 4401 - Amend typos in https://adblockplus.org/en/filters#whitelist (Closed)

Created:
Jan. 5, 2017, 10:08 a.m. by erick
Modified:
July 17, 2017, 9:30 a.m.
Visibility:
Public.

Description

Issue 4401 - Amend typos in https://adblockplus.org/en/filters#whitelist

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M pages/filters.html View 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 4
erick
Jan. 5, 2017, 10:15 a.m. (2017-01-05 10:15:21 UTC) #1
juliandoucette
https://codereview.adblockplus.org/29370746/diff/29370747/pages/filters.html File pages/filters.html (right): https://codereview.adblockplus.org/29370746/diff/29370747/pages/filters.html#newcode20 pages/filters.html:20: <p>{{s9 Once in a while you may notice that ...
Feb. 21, 2017, 3:24 p.m. (2017-02-21 15:24:08 UTC) #2
erick
On 2017/02/21 15:24:08, juliandoucette wrote: > https://codereview.adblockplus.org/29370746/diff/29370747/pages/filters.html > File pages/filters.html (right): > > https://codereview.adblockplus.org/29370746/diff/29370747/pages/filters.html#newcode20 > ...
Feb. 27, 2017, 1:21 p.m. (2017-02-27 13:21:53 UTC) #3
juliandoucette
April 5, 2017, 11:47 a.m. (2017-04-05 11:47:29 UTC) #4
LGTM

https://codereview.adblockplus.org/29370746/diff/29370747/pages/filters.html
File pages/filters.html (right):

https://codereview.adblockplus.org/29370746/diff/29370747/pages/filters.html#...
pages/filters.html:20: <p>{{s9 Once in a while you may notice that one of your
filters, that normally works well, is blocking something that it shouldn't
block. You don't want to remove this filter but you still don't want it to match
in this one case.}}</p>
> I thought this is the correction sentence -> 
> https://issues.adblockplus.org/ticket/4401#comment:5
> Maybe I am missing something. Did I overlook the correct sentence?
> Should there be a new ticket for the paragraph or does it suffice when the
> ticket get a adaption?

1. Please reply to comments inline instead of using the reply button at the
bottom of the review thread
2. You have the correct sentence. I did not recognize it because the correct
sentence was found in the comments instead of the description of the issue. I
have updated the issue as a result. Please update the issue yourself to prevent
this issue if you notice it in the future.

Powered by Google App Engine
This is Rietveld