Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: lib/filterComposer.js

Issue 29370947: Issue 3138 - Improve how context menu "block element" handles iframes (Closed)
Patch Set: Use messaging instead of requiring the info module Created Oct. 19, 2017, 10:52 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ext/background.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/filterComposer.js
diff --git a/lib/filterComposer.js b/lib/filterComposer.js
index 2719386a1ba23b6f8f9374c1b68531e0a239a45c..4137b308afa913f2c79c534227cb9d48dec22b2c 100644
--- a/lib/filterComposer.js
+++ b/lib/filterComposer.js
@@ -169,9 +169,11 @@ function composeFilters(details)
let contextMenuItem = {
title: browser.i18n.getMessage("block_element"),
contexts: ["image", "video", "audio"],
- onclick(page)
+ onclick(page, info)
{
- page.sendMessage({type: "composer.content.contextMenuClicked"});
+ page.sendMessage(
+ {type: "composer.content.contextMenuClicked"}, undefined, info.frameId
+ );
}
};
« no previous file with comments | « ext/background.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld