Unified Diff: test/AppInfoJsObject.cpp
Issue 29371607:
Issue #3593 - Make isolate a fully internal member of the engine
Patch Set: improve unit tests to go with isolate change
Created Jan. 16, 2017, 3:53 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« src/JsEngineInternal.h ('k')
|
test/BaseJsTest.h » ('j')
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: test/AppInfoJsObject.cpp |
| =================================================================== |
| --- a/test/AppInfoJsObject.cpp |
| +++ b/test/AppInfoJsObject.cpp |
| @@ -27,23 +27,27 @@ |
| appInfo.applicationVersion = "5"; |
| appInfo.locale = "2"; |
| appInfo.developmentBuild = true; |
| - AdblockPlus::JsEnginePtr jsEngine(AdblockPlus::JsEngine::New(appInfo)); |
| + auto jsEngine = AdblockPlus::JsEngine::New(appInfo); |
| ASSERT_EQ("1", jsEngine->Evaluate("_appInfo.version")->AsString()); |
| ASSERT_EQ("3", jsEngine->Evaluate("_appInfo.name")->AsString()); |
| ASSERT_EQ("4", jsEngine->Evaluate("_appInfo.application")->AsString()); |
| ASSERT_EQ("5", jsEngine->Evaluate("_appInfo.applicationVersion")->AsString()); |
| ASSERT_EQ("2", jsEngine->Evaluate("_appInfo.locale")->AsString()); |
| ASSERT_TRUE(jsEngine->Evaluate("_appInfo.developmentBuild")->AsBool()); |
| + ASSERT_EQ(1, jsEngine.use_count()); |
| + jsEngine.reset(); |
| } |
| TEST(AppInfoJsObjectTest, DefaultPropertyValues) |
| { |
| AdblockPlus::AppInfo appInfo; |
| - AdblockPlus::JsEnginePtr jsEngine(AdblockPlus::JsEngine::New(appInfo)); |
| + auto jsEngine = AdblockPlus::JsEngine::New(appInfo); |
| ASSERT_EQ("", jsEngine->Evaluate("_appInfo.version")->AsString()); |
| ASSERT_EQ("", jsEngine->Evaluate("_appInfo.name")->AsString()); |
| ASSERT_EQ("", jsEngine->Evaluate("_appInfo.application")->AsString()); |
| ASSERT_EQ("", jsEngine->Evaluate("_appInfo.applicationVersion")->AsString()); |
| ASSERT_EQ("", jsEngine->Evaluate("_appInfo.locale")->AsString()); |
| ASSERT_FALSE(jsEngine->Evaluate("_appInfo.developmentBuild")->AsBool()); |
| + ASSERT_EQ(1, jsEngine.use_count()); |
| + jsEngine.reset(); |
| } |
« no previous file with comments
|
« src/JsEngineInternal.h ('k')
|
test/BaseJsTest.h » ('j')
|
no next file with comments »
