Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29372398: Issue 4804 - Avoid trashing pagemaps prematurely (Closed)

Created:
Jan. 18, 2017, 8:08 a.m. by kzar
Modified:
Feb. 24, 2017, 8:08 a.m.
Reviewers:
Sebastian Noack
CC:
Wladimir Palant
Visibility:
Public.

Description

Issue 4804 - Avoid trashing pagemaps prematurely Depends on this review: https://codereview.adblockplus.org/29362605/

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -40 lines) Patch
M chrome/ext/background.js View 1 4 chunks +43 lines, -35 lines 0 comments Download
M lib/whitelisting.js View 1 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 3
kzar
Patch Set 1 https://codereview.adblockplus.org/29372398/diff/29372399/chrome/ext/background.js File chrome/ext/background.js (left): https://codereview.adblockplus.org/29372398/diff/29372399/chrome/ext/background.js#oldcode132 chrome/ext/background.js:132: ext._removeFromAllPageMaps(tabId); I can't see why to ...
Jan. 18, 2017, 8:12 a.m. (2017-01-18 08:12:09 UTC) #1
Sebastian Noack
NOT LGTM https://codereview.adblockplus.org/29372398/diff/29372399/chrome/ext/background.js File chrome/ext/background.js (left): https://codereview.adblockplus.org/29372398/diff/29372399/chrome/ext/background.js#oldcode132 chrome/ext/background.js:132: ext._removeFromAllPageMaps(tabId); On 2017/01/18 08:12:09, kzar wrote: > ...
Jan. 18, 2017, 11:58 a.m. (2017-01-18 11:58:31 UTC) #2
kzar
Jan. 23, 2017, 10:19 a.m. (2017-01-23 10:19:53 UTC) #3
Rebased

Powered by Google App Engine
This is Rietveld